Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/metrics/variations/variations_registry_syncer_win.cc

Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome_common.gypi » ('j') | chrome/chrome_tests_unit.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/variations/variations_registry_syncer_win.h" 5 #include "chrome/browser/metrics/variations/variations_registry_syncer_win.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/metrics/field_trial.h" 8 #include "base/metrics/field_trial.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 #include "chrome/common/metrics/variations/variations_util.h" 11 #include "chrome/common/metrics/variations/experiment_labels_win.h"
12 #include "chrome/installer/util/google_update_settings.h" 12 #include "chrome/installer/util/google_update_settings.h"
13 #include "chrome/installer/util/install_util.h" 13 #include "chrome/installer/util/install_util.h"
14 14
15 namespace { 15 namespace {
16 16
17 // Delay before performing a registry sync, in seconds. 17 // Delay before performing a registry sync, in seconds.
18 const int kRegistrySyncDelaySeconds = 5; 18 const int kRegistrySyncDelaySeconds = 5;
19 19
20 } // namespace 20 } // namespace
21 21
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 CombineExperimentLabels(variation_labels, other_labels); 74 CombineExperimentLabels(variation_labels, other_labels);
75 75
76 if (!GoogleUpdateSettings::SetExperimentLabels(is_system_install, 76 if (!GoogleUpdateSettings::SetExperimentLabels(is_system_install,
77 combined_labels)) { 77 combined_labels)) {
78 DVLOG(1) << "Error writing Variation labels to the registry: " 78 DVLOG(1) << "Error writing Variation labels to the registry: "
79 << combined_labels; 79 << combined_labels;
80 } 80 }
81 } 81 }
82 82
83 } // namespace chrome_variations 83 } // namespace chrome_variations
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_common.gypi » ('j') | chrome/chrome_tests_unit.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698