GCAPI should append to the existing experiment_labels instead of clobbering them.

chrome/installer/util/google_update_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/google_update_constants.h"
 
 namespace google_update {
 
 const wchar_t kChromeUpgradeCode[] = L"{8A69D345-D564-463C-AFF1-A69D9E530F96}";
 
 const wchar_t kExperimentLabels[] = L"experiment_labels";
+const char16 kExperimentLabelSep[] = L";";

[Alexei Svitkine (slow), 2013/08/30 14:17:19]

Unfortunately, you can't use the L prefix for a string16 literal - since L
corresponds to wchar_t which is 32 bit on some platforms.

Perhaps you can change this to an actual single char16 instead of a string.
Then, you can just use ',' for the value. (Because for ascii chars, its the same
value between a char and a char16).

[gab, 2013/08/30 17:53:11]

That doesn't work either as on Windows char16 can't be set to a non "L" value...

How about using wchar_t, but using WideToUTF16 where this matters (i.e. where
AsciiToUTF16 was previously used anyways..)?

[Alexei Svitkine (slow), 2013/08/30 18:16:11]

I guess a cast of the non-L value to char16 would have worked too, but I'm okay
with this solution as well, mostly because those functions are only used on
Windows where WideToUTF16 is a no-op. (On other platforms all those functions
will be dead-stripped from the binary since they're not used.)

[gab, 2013/08/30 22:57:14]

Pulled those functions out to a Windows specific file.

[Alexei Svitkine (slow), 2013/09/03 15:46:35]

I prefer the Windows specific file actually be renamed to
experiment_labels_win.cc with its own unittest file
(experiment_labels_unittest_win.cc).

[gab, 2013/11/05 22:20:38]

Done.

 
 const wchar_t kGoogleUpdateUpgradeCode[] =
     L"{430FD4D0-B729-4F61-AA34-91526481799D}";
 
 const wchar_t kGoogleUpdateSetupExe[] = L"GoogleUpdateSetup.exe";
 
 const wchar_t kRegPathClients[] = L"Software\\Google\\Update\\Clients";
 const wchar_t kRegPathClientState[] = L"Software\\Google\\Update\\ClientState";
 const wchar_t kRegPathClientStateMedium[] =
     L"Software\\Google\\Update\\ClientStateMedium";
@@ skipping 35 matching lines @@
 const wchar_t kRegReferralField[] = L"referral";
 const wchar_t kRegRenameCmdField[] = L"cmd";
 const wchar_t kRegRunAsUserField[] = L"RunAsUser";
 const wchar_t kRegSendsPingsField[] = L"SendsPings";
 const wchar_t kRegUninstallCmdLine[] = L"UninstallCmdLine";
 const wchar_t kRegUsageStatsField[] = L"usagestats";
 const wchar_t kRegVersionField[] = L"pv";
 const wchar_t kRegWebAccessibleField[] = L"WebAccessible";
 
 }  // namespace google_update