Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2357803002: Add SyntacticEntity, an interface shared by AstNode and Token. (Closed)

Created:
4 years, 3 months ago by Paul Berry
Modified:
4 years, 3 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add SyntacticEntity, an interface shared by AstNode and Token. This allows types to be tightened up for AstNode.childEntities. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/dac96d05849bdf2161855a99ea1a140499109e9e

Patch Set 1 #

Patch Set 2 : Remove redundant comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -136 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 4 chunks +5 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/token.dart View 3 chunks +27 lines, -12 lines 1 comment Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 110 chunks +136 lines, -114 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 3 months ago (2016-09-21 01:38:51 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2357803002/diff/20001/pkg/analyzer/lib/dart/ast/token.dart File pkg/analyzer/lib/dart/ast/token.dart (right): https://codereview.chromium.org/2357803002/diff/20001/pkg/analyzer/lib/dart/ast/token.dart#newcode220 pkg/analyzer/lib/dart/ast/token.dart:220: abstract class SyntacticEntity { Seems like this ought ...
4 years, 3 months ago (2016-09-21 13:21:41 UTC) #3
jwren
On 2016/09/21 13:21:41, Brian Wilkerson wrote: > lgtm > > https://codereview.chromium.org/2357803002/diff/20001/pkg/analyzer/lib/dart/ast/token.dart > File pkg/analyzer/lib/dart/ast/token.dart (right): ...
4 years, 3 months ago (2016-09-21 14:29:33 UTC) #4
Paul Berry
4 years, 3 months ago (2016-09-21 18:23:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
dac96d05849bdf2161855a99ea1a140499109e9e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698