Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 23578017: Follow up cleanups for r222162. (Closed)

Created:
7 years, 3 months ago by alexeypa (please no reviews)
Modified:
7 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Follow up cleanups for r222162. Changes: - ScopedRefNPObject is wrapped into scoped_ptr<> when passed as a callback between threads since ScopedRefNPObject's ref-counting is not thread-safe. - Made HostNPScriptObject::DoGenerateKeyPair a static method to make bouncing between threads safe. - Switched the completion callbacks passed to the daemon controller and pairing registry to use a weak pointer to HostNPScriptObject. - Clarified threading semantic of DaemonController::Delegate. BUG=156257, 173509 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -106 lines) Patch
M remoting/host/plugin/host_script_object.h View 2 chunks +13 lines, -10 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 22 chunks +83 lines, -85 lines 0 comments Download
M remoting/host/setup/daemon_controller.h View 5 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 3 months ago (2013-09-10 16:59:41 UTC) #1
Wez
LGTM, and thanks. :)
7 years, 3 months ago (2013-09-10 17:10:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/23578017/1
7 years, 3 months ago (2013-09-10 17:44:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=75896
7 years, 3 months ago (2013-09-10 21:10:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/23578017/1
7 years, 3 months ago (2013-09-10 22:03:53 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 23:36:40 UTC) #6
Message was sent while issue was closed.
Change committed as 222397

Powered by Google App Engine
This is Rietveld 408576698