Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2357793002: ExternalNavigationHandler: Avoid else-after-return. (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
4 years, 3 months ago
Reviewers:
Maria
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExternalNavigationHandler: Avoid else-after-return. This makes the code much more readable and complies with the Chromium style guide. Committed: https://crrev.com/f463b2126f450e792e5d8fb6171d1b4292ba3579 Cr-Commit-Position: refs/heads/master@{#419979}

Patch Set 1 #

Patch Set 2 : Rewrap. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -44 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 2 5 chunks +50 lines, -44 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Matt Giuca
Hi Maria, I found this code a bit too nested so I removed some "else" ...
4 years, 3 months ago (2016-09-21 00:39:53 UTC) #2
Maria
lgtm
4 years, 3 months ago (2016-09-21 03:59:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357793002/40001
4 years, 3 months ago (2016-09-21 05:30:34 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 05:35:34 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 05:37:27 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f463b2126f450e792e5d8fb6171d1b4292ba3579
Cr-Commit-Position: refs/heads/master@{#419979}

Powered by Google App Engine
This is Rietveld 408576698