arc: Don't show default Arc apps for managed users with Arc-disabled.

arc: Don't show default Arc apps for managed users with Arc-disabled.

TEST=Manually on device. @chromium account has no PlayStore icon
     visible.
TEST=extended browser_tests
BUG=b/31577285
BUG=648796
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aa5c935985a2dcb82cc316bf17007e1f9fbd43f3
Cr-Commit-Position: refs/heads/master@{#423178}

[khmel, 2016-09-20 23:30:28]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-09-20 23:30:29]

Hi Xiyaun,
PTAL

[xiyuan, 2016-09-21 16:10:36]

lgtm

https://codereview.chromium.org/2357763002/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_default_app_list.h (right):

https://codereview.chromium.org/2357763002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_default_app_list.h:57: 
nit: get rid of the empty line and move the block to the end of the declartion
with other accessors, e.g. after app_map()

[khmel, 2016-09-21 16:41:22]

Description was changed from

==========
arc: Don't show default Arc apps for managed users with Arc-disabled.

TEST=Manually on device. @chromium account has no PlayStore icon
     visible.
TEST=extended browser_tests
BUG=b/31577285
BUG=648796
==========

to

==========
arc: Don't show default Arc apps for managed users with Arc-disabled.

TEST=Manually on device. @chromium account has no PlayStore icon
     visible.
TEST=extended browser_tests
BUG=b/31577285
BUG=648796
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[khmel, 2016-09-21 16:47:54]

Patchset #3 (id:40001) has been deleted

[khmel, 2016-09-21 16:53:16]

khmel@chromium.org changed reviewers:
+ bartfab@chromium.org

[khmel, 2016-09-21 16:53:17]

Thanks Xiyuan for review.

Adding Bartosz to review browser tests.

PTAL

https://codereview.chromium.org/2357763002/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_default_app_list.h (right):

https://codereview.chromium.org/2357763002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_default_app_list.h:57: 
On 2016/09/21 16:10:36, xiyuan wrote:
> nit: get rid of the empty line and move the block to the end of the declartion
> with other accessors, e.g. after app_map()

Thanks, overlooked this.

[khmel, 2016-09-21 16:53:19]

Thanks Xiyuan for review.

Adding Bartosz to review browser tests.

PTAL

[khmel, 2016-10-04 06:15:52]

On 2016/09/21 16:53:19, khmel wrote:
> Thanks Xiyuan for review.
> 
> Adding Bartosz to review browser tests.
> 
> PTAL

Hi Bartosz,

Gentle ping,
Thanks

[khmel, 2016-10-04 15:41:33]

khmel@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[khmel, 2016-10-04 15:41:34]

Hi Julian,

Could you please help with reviewing chrome/browser/policy/policy_browsertest.cc

PTAL

Thanks

[pastarmovj, 2016-10-05 08:22:48]

lgtm with a nit.

https://codereview.chromium.org/2357763002/diff/60001/chrome/browser/policy/p...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/2357763002/diff/60001/chrome/browser/policy/p...
chrome/browser/policy/policy_browsertest.cc:4208:
EXPECT_TRUE(!prefs->GetAppIds().empty());
Why not EXPECT_FALSE :)

[khmel, 2016-10-05 15:35:26]

Thanks Julian!

https://codereview.chromium.org/2357763002/diff/60001/chrome/browser/policy/p...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/2357763002/diff/60001/chrome/browser/policy/p...
chrome/browser/policy/policy_browsertest.cc:4208:
EXPECT_TRUE(!prefs->GetAppIds().empty());
On 2016/10/05 08:22:48, pastarmovj wrote:
> Why not EXPECT_FALSE :)

Hmm, I cannot explain :)

[khmel, 2016-10-05 15:35:31]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-10-05 15:35:31]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2357763002/#ps80001
(title: "rebase + nit")

[commit-bot: I haz the power, 2016-10-05 15:35:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 16:20:23]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-05 16:22:12]

Description was changed from

==========
arc: Don't show default Arc apps for managed users with Arc-disabled.

TEST=Manually on device. @chromium account has no PlayStore icon
     visible.
TEST=extended browser_tests
BUG=b/31577285
BUG=648796
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
arc: Don't show default Arc apps for managed users with Arc-disabled.

TEST=Manually on device. @chromium account has no PlayStore icon
     visible.
TEST=extended browser_tests
BUG=b/31577285
BUG=648796
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aa5c935985a2dcb82cc316bf17007e1f9fbd43f3
Cr-Commit-Position: refs/heads/master@{#423178}
==========

[commit-bot: I haz the power, 2016-10-05 16:22:13]

Patchset 4 (id:??) landed as
https://crrev.com/aa5c935985a2dcb82cc316bf17007e1f9fbd43f3
Cr-Commit-Position: refs/heads/master@{#423178}