Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4125)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2357743002: chromeos: Backspace and enter key works as intended. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index 7ed9b51c45170603933a1f1ab9f0da0c8fe466af..c3d4849ea3d3e0a62e9f5ada9822a8741a243fa6 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -76,30 +76,12 @@
opacity: var(--dark-primary-opacity);
}
- .digit-button.backspace-button[disabled] {
+ .digit-button.backspace-button:not([has-content]) {
color: #000;
opacity: 0.26;
padding: 14px;
}
- .digit-button.submit-button {
- color: var(--google-blue-500);
- height: 43px;
- left: 137px;
- margin: 0;
- min-height: 43px;
- min-width: 43px;
- opacity: var(--light-primary-opacity);
- padding: 11.5px 10px;
- position: absolute;
- width: 43px;
- }
-
- .digit-button.submit-button[disabled] {
- color: #000;
- opacity: 0.26;
jdufault 2016/09/20 22:53:59 Unused css?
sammiequon 2016/09/21 01:37:00 Yeah, forgot to remove when the submit button was
- }
-
.digit-button inner-text {
color: var(--paper-blue-grey-700);
display: flex;
@@ -210,12 +192,12 @@
</paper-button>
</div>
<div class="row keyboard bottom-row">
- <div class="digit-button"></div>
+ <div class="digit-button blank-space"></div>
<paper-button class="digit-button" on-tap="onNumberTap_" value="0">
<inner-text>$i18n{pinKeyboard0}</inner-text>
</paper-button>
<paper-icon-button class="digit-button backspace-button"
- disabled="[[!hasInput_(value)]]"
+ has-content$="[[hasInput_(value)]]"
icon="pin-keyboard:backspace"
on-pointerdown="onBackspacePointerDown_"
on-pointerout="onBackspacePointerOut_"

Powered by Google App Engine
This is Rietveld 408576698