chromeos: Backspace and enter key works as intended.

chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'pin-keyboard' is a keyboard that can be used to enter PINs or more generally
  * numeric values.
  *
  * Properties:
@@ skipping 75 matching lines @@
      * The timeoutID used for the auto backspace.
      * @private
      */
     startAutoBackspaceId_: {
       type: Number,
       value: 0
     }
   },
 
   /**
+   * Removes the space/enter key binds from the polymer iron-a11y-keys-behavior.

[jdufault, 2016/09/22 20:04:01]

I would move the function comment into the function itself (above line 100) and
just have /** @override */ here.

[sammiequon, 2016/09/22 23:15:48]

Done.

+   * @override
+   */
+  attached: function() {
+    var digitButtons = Polymer.dom(this.root).querySelectorAll('.digit-button');
+    for (var i = 0; i < digitButtons.length; ++i)
+      digitButtons[i].keyEventTarget = null;
+  },
+
+  /**
    * Gets the container holding the password field.
    * @type {!HTMLInputElement}
    */
   get inputElement() {
     return this.$$('#pin-input');
   },
 
   /** Transfers focus to the input element. */
   focus: function() {
     this.$$('#pin-input').focus();
@@ skipping 96 matching lines @@
     if (event.keyCode == 13) {
       this.firePinSubmitEvent_();
       event.preventDefault();
       return;
     }
   },
 
   /**
    * Keypress does not handle backspace but handles the char codes nicely, so we
    * have a seperate event to process the backspaces.
-   * @param {Event} event Keypress Event object.
+   * @param {Event} event Keydown Event object.
    * @private
    */
   onKeyDown_: function(event) {
     // Backspace pressed.
     if (event.keyCode == 8) {
       this.onPinClear_();
       event.preventDefault();
       return;
     }
   },
@@ skipping 13 matching lines @@
 
     var code = event.keyCode;
 
     // Enter pressed.
     if (code == 13) {
       this.firePinSubmitEvent_();
       event.preventDefault();
       return;
     }
 
+    // Space pressed.
+    if (code == 32) {
+      // Check if target was a number button.
+      if (event.target.hasAttribute('value')) {
+        var numberValue = event.target.getAttribute('value');
+        this.value += numberValue;
+        return;
+      }
+      // Check if target was backspace button.
+      if (event.target.classList.contains('backspace-button')) {
+        this.onPinClear_();
+        return;
+      }
+    }
+
     this.value += String.fromCharCode(code);
   },
 
   /**
    * Disables the submit and backspace button if nothing is entered.
    * @param {string} value
    * @private
    */
   hasInput_: function(value) {
     return value.length > 0;
@@ skipping 30 matching lines @@
     // does not contain decimals.
     // This heuristic will fail for inputs like '1.0'.
     //
     // Since we still support users entering their passwords through the PIN
     // keyboard, we swap the input box to rtl when we think it is a password
     // (just numbers), if the document direction is rtl.
     return (document.dir == 'rtl') && !Number.isInteger(+password);
   },
 });
 })();