chromeos: Backspace and enter key works as intended.

chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would cause an additional number to get appended to the password string before sending the password. Fixed this by removing the default enter key = tap on polymers button.

BUG=647709, 648772
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d3ca9dd939132cfcc9be5f7aac1c4086b4a94a45
Cr-Commit-Position: refs/heads/master@{#420658}

[sammiequon, 2016-09-20 22:31:08]

Description was changed from

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
==========

to

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-09-20 22:35:58]

Description was changed from

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-09-20 22:35:58]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org

[sammiequon, 2016-09-20 22:41:19]

Patchset #1 (id:1) has been deleted

[sammiequon, 2016-09-20 22:42:10]

jdufault@ - Please take a look. Thanks!

[jdufault, 2016-09-20 22:54:00]

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (left):

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:100: opacity:
0.26;
Unused css?

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:106:
digitButtons[i]._unlistenKeyEventListeners();
Is this a polymer internal method? If so, we should try to find another way to
fix the problem.

[sammiequon, 2016-09-21 01:37:00]

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (left):

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:100: opacity:
0.26;
On 2016/09/20 22:53:59, jdufault wrote:
> Unused css?

Yeah, forgot to remove when the submit button was moved to the user pod.

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2357743002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:106:
digitButtons[i]._unlistenKeyEventListeners();
On 2016/09/20 22:54:00, jdufault wrote:
> Is this a polymer internal method? If so, we should try to find another way to
> fix the problem.

Done. Replaced with keyEventTarget which is part of the paper-button public api.

[jdufault, 2016-09-22 20:04:01]

lgtm

https://codereview.chromium.org/2357743002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2357743002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:96: * Removes the
space/enter key binds from the polymer iron-a11y-keys-behavior.
I would move the function comment into the function itself (above line 100) and
just have /** @override */ here.

[sammiequon, 2016-09-22 23:15:48]

https://codereview.chromium.org/2357743002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2357743002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:96: * Removes the
space/enter key binds from the polymer iron-a11y-keys-behavior.
On 2016/09/22 20:04:01, jdufault wrote:
> I would move the function comment into the function itself (above line 100)
and
> just have /** @override */ here.

Done.

[sammiequon, 2016-09-22 23:15:59]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[sammiequon, 2016-09-22 23:16:09]

sammiequon@chromium.org changed reviewers:
+ xiyuan@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:16:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sammiequon, 2016-09-22 23:17:03]

xiyuan@ - Please take a look. Thanks!

[commit-bot: I haz the power, 2016-09-23 00:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 00:47:10]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-09-23 16:32:45]

lgtm

https://codereview.chromium.org/2357743002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2357743002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:262: this.value
+= numberValue;
nit: get rid of |numberValue| and use event.target.getAttribute('value')
directly here.

[sammiequon, 2016-09-23 16:41:21]

https://codereview.chromium.org/2357743002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2357743002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:262: this.value
+= numberValue;
On 2016/09/23 16:32:45, xiyuan wrote:
> nit: get rid of |numberValue| and use event.target.getAttribute('value')
> directly here.

Done.

[sammiequon, 2016-09-23 16:41:25]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2016-09-23 16:41:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2357743002/#ps120001
(title: "Nit.")

[commit-bot: I haz the power, 2016-09-23 16:41:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:04:47]

Description was changed from

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-23 18:04:48]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-09-23 18:08:16]

Description was changed from

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
chromeos: Backspace and enter key works as intended.

Previously clicking the backspace to erase all characters would cause input box
to lose focus. Fixed this by removing the disabled state.
Previously clicking enter keyboard key after touching a number button would
cause an additional number to get appended to the password string before sending
the password. Fixed this by removing the default enter key = tap on polymers
button.

BUG=647709,648772
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d3ca9dd939132cfcc9be5f7aac1c4086b4a94a45
Cr-Commit-Position: refs/heads/master@{#420658}
==========

[commit-bot: I haz the power, 2016-09-23 18:08:17]

Patchset 6 (id:??) landed as
https://crrev.com/d3ca9dd939132cfcc9be5f7aac1c4086b4a94a45
Cr-Commit-Position: refs/heads/master@{#420658}