Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2357713002: Revert of Stop closing filled paths in GrShape (Closed)

Created:
4 years, 3 months ago by fmalita_google_do_not_use
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Stop closing filled paths in GrShape (patchset #1 id:1 of https://codereview.chromium.org/2355833002/ ) Reason for revert: Triggers msaa16 asserts: https://build.chromium.org/p/client.skia/builders/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/4236/steps/test_skia%20on%20Windows/logs/stdio c:\b\work\skia\src\gpu\grmesh.h:76: fatal error: "assert(indexCount)" Caught exception 2147483651 EXCEPTION_BREAKPOINT, was running: msaa16 svg cartman.svg Likely culprit: msaa16 svg cartman.svg Original issue's description: > Stop closing filled paths in GrShape > > This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002 > > Committed: https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8 TBR=robertphillips@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/e918417dc34c0856822e6955b788e962c289ca3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/gpu/GrShape.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
fmalita_google_do_not_use
Created Revert of Stop closing filled paths in GrShape
4 years, 3 months ago (2016-09-20 21:06:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357713002/1
4 years, 3 months ago (2016-09-20 21:06:55 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 21:06:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e918417dc34c0856822e6955b788e962c289ca3d

Powered by Google App Engine
This is Rietveld 408576698