Filler sizes have to be Smis, fix x64 breakage.

src/hydrogen-instructions.cc

Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index 07e78f3368e251ea89cd57d81d6045a8e873f4b7..6f13b5ced97e7092e04292b8950ec548fce38a39 100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -3296,7 +3296,11 @@ void HAllocate::HandleSideEffectDominator(GVNFlag side_effect,
   }
 
   HInstruction* new_dominator_size_constant = HConstant::CreateAndInsertBefore(
-      zone, context(), new_dominator_size, dominator_allocate);
+      zone,
+      context(),
+      new_dominator_size,
+      Representation::None(),
+      dominator_allocate);
   dominator_allocate->UpdateSize(new_dominator_size_constant);
 
 #ifdef VERIFY_HEAP
@@ -3394,6 +3398,7 @@ void HAllocate::UpdateFreeSpaceFiller(int32_t free_space_size) {
       context(),
       filler_free_space_size_->value()->GetInteger32Constant() +
           free_space_size,
+      Representation::Smi(),

[Jakob Kummerow, 2013/08/27 11:43:34]

I'd like a comment here, please. Roughly:

We must explicitly force Smi representation for this constant, because on x64 we
would otherwise automatically choose int32, but the actual store requires a
Smi-tagged value.

       filler_free_space_size_);
   filler_free_space_size_->UpdateValue(new_free_space_size);
 }
@@ -3420,9 +3425,10 @@ void HAllocate::CreateFreeSpaceFiller(int32_t free_space_size) {
   store_map->InsertAfter(filler_map);
 
   HConstant* filler_size = HConstant::CreateAndInsertAfter(
-      zone, context(), free_space_size, store_map);
+      zone, context(), free_space_size, Representation::Smi(), store_map);

[Jakob Kummerow, 2013/08/27 11:43:34]

Consider repeating the comment here, or an abbreviated version:

// Must force Smi representation for x64 (see comment above).

   HObjectAccess access =
-      HObjectAccess::ForJSObjectOffset(FreeSpace::kSizeOffset);
+      HObjectAccess::ForJSObjectOffset(FreeSpace::kSizeOffset,
+          Representation::Smi());
   HStoreNamedField* store_size = HStoreNamedField::New(zone, context(),
       free_space_instr, access, filler_size);
   store_size->SetFlag(HValue::kHasNoObservableSideEffects);