Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 23577002: Filler sizes have to be Smis, fix x64 breakage. (Closed)

Created:
7 years, 3 months ago by Hannes Payer (out of office)
Modified:
7 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Filler sizes have to be Smis, fix x64 breakage. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16355

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M src/hydrogen-instructions.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
7 years, 3 months ago (2013-08-27 11:27:36 UTC) #1
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/23577002/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/23577002/diff/1/src/hydrogen-instructions.cc#newcode3401 src/hydrogen-instructions.cc:3401: Representation::Smi(), I'd like a comment here, ...
7 years, 3 months ago (2013-08-27 11:43:34 UTC) #2
Hannes Payer (out of office)
7 years, 3 months ago (2013-08-27 11:51:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698