Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

Issue 2357633003: Move buildFilterOperations to FilterEffectBuilder (Closed)
Patch Set: Element -> Node Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
index cffa41ac1f0995190ba92a63e18654a474a40d77..5d4bce1cdabaf26ff512e42ebf30dba3bf81260b 100644
--- a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
@@ -41,6 +41,7 @@
#include "core/layout/LayoutBoxModelObject.h"
#include "core/layout/LayoutObject.h"
#include "core/layout/compositing/CompositedLayerMapping.h"
+#include "core/paint/FilterEffectBuilder.h"
#include "core/paint/PaintLayer.h"
#include "platform/animation/AnimationTranslationUtil.h"
#include "platform/animation/CompositorAnimation.h"
@@ -53,7 +54,6 @@
#include "platform/animation/CompositorTransformKeyframe.h"
#include "platform/geometry/FloatBox.h"
#include "public/platform/Platform.h"
-#include "public/platform/WebCompositorSupport.h"
#include "wtf/PtrUtil.h"
#include <algorithm>
#include <cmath>
@@ -416,6 +416,12 @@ bool CompositorAnimations::convertTimingForCompositor(const Timing& timing, doub
namespace {
+CompositorFilterOperations toCompositorFilterOperations(const FilterOperations& inOperations)
loyso (OOO) 2016/09/22 04:55:51 There is no need to establish this function - ther
+{
+ FilterEffectBuilder builder(nullptr, FloatRect(), 1);
loyso (OOO) 2016/09/22 04:55:51 Can we have a dedicated ctor with no args for this
+ return builder.buildFilterOperations(inOperations);
+}
+
void addKeyframeToCurve(CompositorFilterAnimationCurve& curve, Keyframe::PropertySpecificKeyframe* keyframe,
const AnimatableValue* value, const TimingFunction& keyframeTimingFunction)
{

Powered by Google App Engine
This is Rietveld 408576698