Issue 2357623003: Submit button incompatiable with desktop chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2357623003: Submit button incompatiable with desktop chrome. (Closed)

Created:
4 years, 3 months ago by jdufault

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Submit button incompatiable with desktop chrome. Due to some complications I was not actually reproduce these bugs on desktop chrome. They should at the very least fix the bugs where the submit button shows up. I have confirmed they work as before on the chromeos side. BUG=643066, 643069, 644325, 644843 Review-Url: https://codereview.chromium.org/2326833002 Cr-Commit-Position: refs/heads/master@{#418384} (cherry picked from commit 8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4) Committed: https://chromium.googlesource.com/chromium/src/+/80dd269ca1f309fc184c94e6e4f642b43cd563c5

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -4 lines)			Patch
M	ui/login/account_picker/user_pod_row.css	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/login/account_picker/user_pod_row.js	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	ui/login/account_picker/user_pod_template.html	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

jdufault

4 years, 3 months ago (2016-09-20 23:31:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
80dd269ca1f309fc184c94e6e4f642b43cd563c5.