chrome/browser/task_manager/task_manager_browsertest.cc - Issue 23576007: FindBrowserWithWebContents now recognises DevTool's embedded WebContent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 23576007: FindBrowserWithWebContents now recognises DevTool's embedded WebContent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Browser test added Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/tab_contents_resource_provider.cc ('k') | chrome/browser/ui/browser_finder.cc » ('j') | chrome/browser/ui/browser_finder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_browsertest.cc

diff --git a/chrome/browser/task_manager/task_manager_browsertest.cc b/chrome/browser/task_manager/task_manager_browsertest.cc

index d3e3a524a196e08cde5352f2a39de88dc6bdd8e4..6851bc4f2fae1eea80207cf1247da703015c8cc5 100644

--- a/chrome/browser/task_manager/task_manager_browsertest.cc

+++ b/chrome/browser/task_manager/task_manager_browsertest.cc

@@ -9,6 +9,7 @@

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

+#include "chrome/browser/devtools/devtools_window.h"

#include "chrome/browser/extensions/extension_browsertest.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

@@ -496,4 +497,14 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, DISABLED_WebWorkerJSHeapMemory) {

EXPECT_GE(result, minimal_heap_size);

}

+IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeInTabDevToolsWindow) {

+ DevToolsWindow* dev_tools = DevToolsWindow::ToggleDevToolsWindow(

+ model()->GetResourceWebContents(1)->GetRenderViewHost(),

+ true,

+ DEVTOOLS_TOGGLE_ACTION_INSPECT);

+ // Dock side bottom should be the default.

+ ASSERT_EQ(DEVTOOLS_DOCK_SIDE_BOTTOM, dev_tools->dock_side());

+ TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);

vabr (Chromium) 2013/08/29 10:38:46 I have an issue with this browser test. If the Dev

#endif