Issue 23576002: Remove deprecated methods from debugger API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23576002: Remove deprecated methods from debugger API (Closed)

Created:
7 years, 3 months ago by yurys

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer, Yang, loislo

CC:
v8-dev, alph

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove deprecated methods from debugger API Deleting SetDebugEventListener and SetMessageHandler from v8::Debug. this methods were deprecated in 3.20 https://code.google.com/p/v8/source/browse/branches/3.20/include/v8-debug.h but in fact they have been superseded by SetDebugEventListener2 and SetMessageHandler2 long ago. BUG=None R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16379

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+222 lines, -366 lines)			Patch
M	include/v8-debug.h	View	4 chunks	+3 lines, -41 lines	0 comments	Download
M	src/api.cc	View	2 chunks	+0 lines, -60 lines	0 comments	Download
M	src/isolate.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	157 chunks	+219 lines, -263 lines	0 comments	Download

Total messages: 5 (0 generated)

yurys

7 years, 3 months ago (2013-08-28 07:12:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r16379 (presubmit successful).