Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: src/compiler/x87/code-generator-x87.cc

Issue 2357583003: [turbofan] Remove bogus constant materialization from frame. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | test/mjsunit/regress/regress-crbug-648539.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/x87/code-generator-x87.cc
diff --git a/src/compiler/x87/code-generator-x87.cc b/src/compiler/x87/code-generator-x87.cc
index fd2994b37b0b3320687d56239b9eda0b9ec2bae3..9820186223901077c9b2f0c935c91c4ee3224f8b 100644
--- a/src/compiler/x87/code-generator-x87.cc
+++ b/src/compiler/x87/code-generator-x87.cc
@@ -2517,18 +2517,7 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,
Constant src_constant = g.ToConstant(source);
if (src_constant.type() == Constant::kHeapObject) {
Handle<HeapObject> src = src_constant.ToHeapObject();
- int slot;
- if (IsMaterializableFromFrame(src, &slot)) {
- if (destination->IsRegister()) {
- Register dst = g.ToRegister(destination);
- __ mov(dst, g.SlotToOperand(slot));
- } else {
- DCHECK(destination->IsStackSlot());
- Operand dst = g.ToOperand(destination);
- __ push(g.SlotToOperand(slot));
- __ pop(dst);
- }
- } else if (destination->IsRegister()) {
+ if (destination->IsRegister()) {
Register dst = g.ToRegister(destination);
__ LoadHeapObject(dst, src);
} else {
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | test/mjsunit/regress/regress-crbug-648539.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698