Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/arm/code-generator-arm.cc

Issue 2357583003: [turbofan] Remove bogus constant materialization from frame. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm/macro-assembler-arm.h" 7 #include "src/arm/macro-assembler-arm.h"
8 #include "src/compilation-info.h" 8 #include "src/compilation-info.h"
9 #include "src/compiler/code-generator-impl.h" 9 #include "src/compiler/code-generator-impl.h"
10 #include "src/compiler/gap-resolver.h" 10 #include "src/compiler/gap-resolver.h"
(...skipping 1802 matching lines...) Expand 10 before | Expand all | Expand 10 after
1813 case Constant::kFloat64: 1813 case Constant::kFloat64:
1814 __ Move(dst, 1814 __ Move(dst,
1815 isolate()->factory()->NewNumber(src.ToFloat64(), TENURED)); 1815 isolate()->factory()->NewNumber(src.ToFloat64(), TENURED));
1816 break; 1816 break;
1817 case Constant::kExternalReference: 1817 case Constant::kExternalReference:
1818 __ mov(dst, Operand(src.ToExternalReference())); 1818 __ mov(dst, Operand(src.ToExternalReference()));
1819 break; 1819 break;
1820 case Constant::kHeapObject: { 1820 case Constant::kHeapObject: {
1821 Handle<HeapObject> src_object = src.ToHeapObject(); 1821 Handle<HeapObject> src_object = src.ToHeapObject();
1822 Heap::RootListIndex index; 1822 Heap::RootListIndex index;
1823 int slot; 1823 if (IsMaterializableFromRoot(src_object, &index)) {
1824 if (IsMaterializableFromFrame(src_object, &slot)) {
1825 __ ldr(dst, g.SlotToMemOperand(slot));
1826 } else if (IsMaterializableFromRoot(src_object, &index)) {
1827 __ LoadRoot(dst, index); 1824 __ LoadRoot(dst, index);
1828 } else { 1825 } else {
1829 __ Move(dst, src_object); 1826 __ Move(dst, src_object);
1830 } 1827 }
1831 break; 1828 break;
1832 } 1829 }
1833 case Constant::kRpoNumber: 1830 case Constant::kRpoNumber:
1834 UNREACHABLE(); // TODO(dcarney): loading RPO constants on arm. 1831 UNREACHABLE(); // TODO(dcarney): loading RPO constants on arm.
1835 break; 1832 break;
1836 } 1833 }
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
1969 padding_size -= v8::internal::Assembler::kInstrSize; 1966 padding_size -= v8::internal::Assembler::kInstrSize;
1970 } 1967 }
1971 } 1968 }
1972 } 1969 }
1973 1970
1974 #undef __ 1971 #undef __
1975 1972
1976 } // namespace compiler 1973 } // namespace compiler
1977 } // namespace internal 1974 } // namespace internal
1978 } // namespace v8 1975 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698