Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2357583003: [turbofan] Remove bogus constant materialization from frame. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove bogus constant materialization from frame. This removes an optimization from the code generator that tries to materialize certain constants (i.e. context and closure) from the stackframe when possible. This does not work with Harmony tail calls which are split into several instructions. There have already been numerous bugs in this optimization, it is too fragile in its current form. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-648539 BUG=chromium:648539 Committed: https://crrev.com/81f43429943aabcc9c970562c25f2725c6fc778f Cr-Commit-Position: refs/heads/master@{#39583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -78 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -12 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -12 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-648539.js View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-21 08:54:34 UTC) #3
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-21 08:54:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357583003/1
4 years, 3 months ago (2016-09-21 09:23:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 09:30:52 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 09:31:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81f43429943aabcc9c970562c25f2725c6fc778f
Cr-Commit-Position: refs/heads/master@{#39583}

Powered by Google App Engine
This is Rietveld 408576698