ServiceWorker: Added --mojo-service-worker to the browser tests

ServiceWorker: Added --mojo-service-worker to the browser tests

In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
to use the parameterized tests for flipping the flag.

BUG=629701
Committed: https://crrev.com/baa9cb520b6ee800f7633fb966474bf12325b8d9
Cr-Commit-Position: refs/heads/master@{#421462}

[shimazu, 2016-09-20 08:04:39]

Description was changed from

==========
ServiceWorker: Added --mojo-service-worker to the browser tests

In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
to use the parameterized tests.

BUG=629701
==========

to

==========
ServiceWorker: Added --mojo-service-worker to the browser tests

In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
to use the parameterized tests for flipping the flag.

BUG=629701
==========

[shimazu, 2016-09-20 08:05:50]

shimazu@chromium.org changed reviewers:
+ horo@chromium.org

[shimazu, 2016-09-20 08:05:51]

PTAL

[horo, 2016-09-20 09:05:52]

lgtm with nits

https://codereview.chromium.org/2357543002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/2357543002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:381: bool
is_mojo_enabled() { return is_mojo_enabled_; }
nit: bool is_mojo_enabled() const { return is_mojo_enabled_; }

https://codereview.chromium.org/2357543002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:2073: }  //
namespace content
nit: space

[shimazu, 2016-09-21 01:16:23]

https://codereview.chromium.org/2357543002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/2357543002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:381: bool
is_mojo_enabled() { return is_mojo_enabled_; }
On 2016/09/20 09:05:52, horo wrote:
> nit: bool is_mojo_enabled() const { return is_mojo_enabled_; }

Done.

https://codereview.chromium.org/2357543002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:2073: }  //
namespace content
On 2016/09/20 09:05:52, horo wrote:
> nit: space

Done.

[shimazu, 2016-09-28 05:34:08]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2016-09-28 05:34:09]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2357543002/#ps20001
(title: "Added const and a space")

[commit-bot: I haz the power, 2016-09-28 05:34:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 06:29:33]

Description was changed from

==========
ServiceWorker: Added --mojo-service-worker to the browser tests

In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
to use the parameterized tests for flipping the flag.

BUG=629701
==========

to

==========
ServiceWorker: Added --mojo-service-worker to the browser tests

In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
to use the parameterized tests for flipping the flag.

BUG=629701
==========

[commit-bot: I haz the power, 2016-09-28 06:29:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 06:31:47]

Description was changed from

==========
ServiceWorker: Added --mojo-service-worker to the browser tests

In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
to use the parameterized tests for flipping the flag.

BUG=629701
==========

to

==========
ServiceWorker: Added --mojo-service-worker to the browser tests

In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
to use the parameterized tests for flipping the flag.

BUG=629701

Committed: https://crrev.com/baa9cb520b6ee800f7633fb966474bf12325b8d9
Cr-Commit-Position: refs/heads/master@{#421462}
==========

[commit-bot: I haz the power, 2016-09-28 06:31:48]

Patchset 2 (id:??) landed as
https://crrev.com/baa9cb520b6ee800f7633fb966474bf12325b8d9
Cr-Commit-Position: refs/heads/master@{#421462}

[jwd, 2016-09-28 14:20:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2380723002/ by jwd@chromium.org.

The reason for reverting is: Revert so a revert of
https://codereview.chromium.org/2227593002 will compile..