Issue 235753003: Don't use default GDI SkFontMgr in getFontFamilyForScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235753003: Don't use default GDI SkFontMgr in getFontFamilyForScript (Closed)

Created:
6 years, 8 months ago by scottmg

Modified:
6 years, 8 months ago

Reviewers:
eae

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, ananta

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Don't use default GDI SkFontMgr in getFontFamilyForScript Instead of using SkTypeface directly which goes through the default Skia FontMgr, pass ours through so that when enabling DirectWrite we don't use the GDI one. R=eae@chromium.org BUG=362694 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171399

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -40 lines)			Patch
M	Source/platform/fonts/win/FontCacheSkiaWin.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/platform/fonts/win/FontFallbackWin.h	View	2 chunks	+4 lines, -8 lines	1 comment	Download
M	Source/platform/fonts/win/FontFallbackWin.cpp	View	8 chunks	+11 lines, -31 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

https://codereview.chromium.org/235753003/diff/1/Source/platform/fonts/win/FontFallbackWin.h File Source/platform/fonts/win/FontFallbackWin.h (left): https://codereview.chromium.org/235753003/diff/1/Source/platform/fonts/win/FontFallbackWin.h#oldcode43 Source/platform/fonts/win/FontFallbackWin.h:43: // Return a font family that can render |characters| ...

6 years, 8 months ago (2014-04-11 20:48:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/235753003/1

6 years, 8 months ago (2014-04-12 15:17:29 UTC) #4

Message was sent while issue was closed.

Change committed as 171399

Expand Messages | Collapse Messages