Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2357513005: kernel->ssa: support string concatenations/interpolations (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

kernel->ssa: support string concatenations/interpolations R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/b114cfc72433667f8b4ff9b81ed1c2083f4cf3ea

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -1 line) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/ssa/kernel_string_builder.dart View 1 chunk +75 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/expressions_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/literals_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 3 months ago (2016-09-20 22:56:35 UTC) #2
Johnni Winther
lgtm
4 years, 3 months ago (2016-09-21 09:33:10 UTC) #3
Harry Terkelsen
4 years, 3 months ago (2016-09-21 17:42:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b114cfc72433667f8b4ff9b81ed1c2083f4cf3ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698