Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2357513004: Test summary resynthesis of unresolved annotations. (Closed)

Created:
4 years, 3 months ago by Paul Berry
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test summary resynthesis of unresolved annotations. Unresolved annotations were being summarized properly, but this was untested, and testing them required some bug fixes to the test infrastructure (mostly due to quirks introduced by dartbug.com/25706). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/36a0807331e9414fd410308873ef8ecf221f8b2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -6 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 4 chunks +59 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 3 months ago (2016-09-20 20:10:01 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-20 20:13:30 UTC) #3
Paul Berry
4 years, 3 months ago (2016-09-20 20:43:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
36a0807331e9414fd410308873ef8ecf221f8b2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698