Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2357433002: Revert of [crankshaft] Protect against deopt loops from string length overflows. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [crankshaft] Protect against deopt loops from string length overflows. (patchset #1 id:1 of https://codereview.chromium.org/2348293002/ ) Reason for revert: Mean https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10910 Original issue's description: > [crankshaft] Protect against deopt loops from string length overflows. > > Crankshaft just unconditionally deoptimizes the code when the length of > a string addition result would overflow. In order to protect against > deopt loops we insert a global protector cell. > > We will use the same mechanism for inlining certain string additions > into TurboFan as well, and protecting against overflow (we will also > extend this to deal with String.prototype.concat and friends once we > get there). > > BUG=v8:5404 > R=jarin@chromium.org,hpayer@chromium.org > > Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71 > Cr-Commit-Position: refs/heads/master@{#39511} TBR=hpayer@chromium.org,jarin@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5404 Committed: https://crrev.com/53510f6a800460a8f9e6432e8bcff400ad895926 Cr-Commit-Position: refs/heads/master@{#39518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -61 lines) Patch
M src/crankshaft/hydrogen.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/factory.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +2 lines, -1 line 0 comments Download
D test/mjsunit/regress/regress-5404.js View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [crankshaft] Protect against deopt loops from string length overflows.
4 years, 3 months ago (2016-09-19 21:49:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357433002/1
4 years, 3 months ago (2016-09-19 21:49:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 21:49:50 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:50:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53510f6a800460a8f9e6432e8bcff400ad895926
Cr-Commit-Position: refs/heads/master@{#39518}

Powered by Google App Engine
This is Rietveld 408576698