Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/inspector/v8-stack-trace-impl.h

Issue 2357423002: Improve stack traces for async functions (Closed)
Patch Set: Format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INSPECTOR_V8STACKTRACEIMPL_H_ 5 #ifndef V8_INSPECTOR_V8STACKTRACEIMPL_H_
6 #define V8_INSPECTOR_V8STACKTRACEIMPL_H_ 6 #define V8_INSPECTOR_V8STACKTRACEIMPL_H_
7 7
8 #include "src/base/macros.h" 8 #include "src/base/macros.h"
9 #include "src/inspector/protocol/Forward.h" 9 #include "src/inspector/protocol/Forward.h"
10 #include "src/inspector/protocol/Runtime.h" 10 #include "src/inspector/protocol/Runtime.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 String16 m_scriptId; 51 String16 m_scriptId;
52 String16 m_scriptName; 52 String16 m_scriptName;
53 int m_lineNumber; 53 int m_lineNumber;
54 int m_columnNumber; 54 int m_columnNumber;
55 }; 55 };
56 56
57 static void setCaptureStackTraceForUncaughtExceptions(v8::Isolate*, 57 static void setCaptureStackTraceForUncaughtExceptions(v8::Isolate*,
58 bool capture); 58 bool capture);
59 static std::unique_ptr<V8StackTraceImpl> create( 59 static std::unique_ptr<V8StackTraceImpl> create(
60 V8Debugger*, int contextGroupId, v8::Local<v8::StackTrace>, 60 V8Debugger*, int contextGroupId, v8::Local<v8::StackTrace>,
61 size_t maxStackSize, const String16& description = String16()); 61 size_t maxStackSize, const String16& description = String16(),
62 bool skipInitialFrame = false);
62 static std::unique_ptr<V8StackTraceImpl> capture( 63 static std::unique_ptr<V8StackTraceImpl> capture(
63 V8Debugger*, int contextGroupId, size_t maxStackSize, 64 V8Debugger*, int contextGroupId, size_t maxStackSize,
64 const String16& description = String16()); 65 const String16& description = String16(), bool skipInitialFrame = false);
65 66
66 // This method drops the async chain. Use cloneImpl() instead. 67 // This method drops the async chain. Use cloneImpl() instead.
67 std::unique_ptr<V8StackTrace> clone() override; 68 std::unique_ptr<V8StackTrace> clone() override;
68 std::unique_ptr<V8StackTraceImpl> cloneImpl(); 69 std::unique_ptr<V8StackTraceImpl> cloneImpl();
69 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail( 70 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail(
70 V8Debugger*) const; 71 V8Debugger*) const;
71 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectImpl() 72 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectImpl()
72 const; 73 const;
73 ~V8StackTraceImpl() override; 74 ~V8StackTraceImpl() override;
74 75
(...skipping 15 matching lines...) Expand all
90 91
91 int m_contextGroupId; 92 int m_contextGroupId;
92 String16 m_description; 93 String16 m_description;
93 std::vector<Frame> m_frames; 94 std::vector<Frame> m_frames;
94 std::unique_ptr<V8StackTraceImpl> m_parent; 95 std::unique_ptr<V8StackTraceImpl> m_parent;
95 }; 96 };
96 97
97 } // namespace v8_inspector 98 } // namespace v8_inspector
98 99
99 #endif // V8_INSPECTOR_V8STACKTRACEIMPL_H_ 100 #endif // V8_INSPECTOR_V8STACKTRACEIMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698