Improve stack traces for async functions

src/inspector/v8-debugger.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INSPECTOR_V8DEBUGGER_H_
 #define V8_INSPECTOR_V8DEBUGGER_H_
 
 #include "src/base/macros.h"
 #include "src/inspector/java-script-call-frame.h"
 #include "src/inspector/protocol/Forward.h"
@@ skipping 72 matching lines @@
   int maxAsyncCallChainDepth() { return m_maxAsyncCallStackDepth; }
   V8StackTraceImpl* currentAsyncCallChain();
   void setAsyncCallStackDepth(V8DebuggerAgentImpl*, int);
   std::unique_ptr<V8StackTraceImpl> createStackTrace(v8::Local<v8::StackTrace>);
   std::unique_ptr<V8StackTraceImpl> captureStackTrace(bool fullStack);
 
   v8::MaybeLocal<v8::Array> internalProperties(v8::Local<v8::Context>,
                                                v8::Local<v8::Value>);
 
   void asyncTaskScheduled(const StringView& taskName, void* task,
-                          bool recurring);
-  void asyncTaskScheduled(const String16& taskName, void* task, bool recurring);
+                          bool recurring, int skipInitialFrames = 0);

[kozy, 2016/09/23 01:27:36]

Please not expose this argument in public API. You can mark frames somehow and
then filter them on frontend side or don't report it from V8 api.

[Dan Ehrenberg, 2016/09/23 04:11:31]

As we discussed off-line, there's nothing special about these stack frames to
mark. I changed the debugger API to not expose skipping initial frames (except
through V8's debug events), and restricted the code to be stricter and only skip
one frame.

+  void asyncTaskScheduled(const String16& taskName, void* task, bool recurring,
+                          int skipInitialFrames = 0);
   void asyncTaskCanceled(void* task);
   void asyncTaskStarted(void* task);
   void asyncTaskFinished(void* task);
   void allAsyncTasksCanceled();
 
   void muteScriptParsedEvents();
   void unmuteScriptParsedEvents();
 
   V8InspectorImpl* inspector() { return m_inspector; }
 
@@ skipping 46 matching lines @@
   protocol::HashSet<void*> m_recurringTasks;
   int m_maxAsyncCallStackDepth;
   std::vector<void*> m_currentTasks;
   std::vector<std::unique_ptr<V8StackTraceImpl>> m_currentStacks;
   protocol::HashMap<V8DebuggerAgentImpl*, int> m_maxAsyncCallStackDepthMap;
 };
 
 }  // namespace v8_inspector
 
 #endif  // V8_INSPECTOR_V8DEBUGGER_H_