Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2357413004: sRGB cleanup in image filters. Ensure we configure paints correctly. (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

sRGB cleanup in image filters. Ensure we configure paints correctly. Net effect of the two calls is (basically) the same, but given that we're propagating from isGammaCorrect on the DC, I figured it makes sense to use the same-named API. More importantly, a couple places had slipped through, so those draws would ignore sRGB-ness of inputs entirely. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357413004 Committed: https://skia.googlesource.com/skia/+/5a9c2f110e4f1a78d9bfedcf708168909706d7fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Brian Osman
4 years, 2 months ago (2016-09-22 20:32:39 UTC) #6
robertphillips
lgtm. Do we need both entry points?
4 years, 2 months ago (2016-09-22 21:11:41 UTC) #7
Brian Osman
On 2016/09/22 21:11:41, robertphillips wrote: > lgtm. Do we need both entry points? Yeah, setGammaCorrect ...
4 years, 2 months ago (2016-09-22 21:16:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357413004/1
4 years, 2 months ago (2016-09-22 21:17:21 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 21:51:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5a9c2f110e4f1a78d9bfedcf708168909706d7fd

Powered by Google App Engine
This is Rietveld 408576698