Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2357413003: Remove coordinates from GestureStateListener onSingleTap() (Closed)

Created:
4 years, 2 months ago by Tima Vaisburd
Modified:
4 years, 2 months ago
Reviewers:
Ted C, boliu
CC:
chromium-reviews, jam, twellington+watch_chromium.org, donnd+watch_chromium.org, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove coordinates from GestureStateListener onSingleTap() We convert the coordinates from DIP to pixels and pass them to this method but no one seems to use them. This CL proposes to remove the coordinates altogether. BUG=620929 Committed: https://crrev.com/eabef685a78017bbadd151e4e22cd7c25763070a Cr-Commit-Position: refs/heads/master@{#420527}

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
Tima Vaisburd
Another small deletion. PTAL.
4 years, 2 months ago (2016-09-22 21:37:40 UTC) #7
boliu
lgtm
4 years, 2 months ago (2016-09-22 22:43:57 UTC) #8
Ted C
lgtm
4 years, 2 months ago (2016-09-23 01:03:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357413003/1
4 years, 2 months ago (2016-09-23 01:04:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 01:10:43 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 01:13:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eabef685a78017bbadd151e4e22cd7c25763070a
Cr-Commit-Position: refs/heads/master@{#420527}

Powered by Google App Engine
This is Rietveld 408576698