bluetooth: Add device list retrieval for chrome://bluetooth-internals

device/bluetooth/public/interfaces/bluetooth.mojom

Index: device/bluetooth/public/interfaces/bluetooth.mojom
diff --git a/device/bluetooth/public/interfaces/bluetooth.mojom b/device/bluetooth/public/interfaces/bluetooth.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..e6d4126b3ee0b18629d053e34ed86ef4bc02e896
--- /dev/null
+++ b/device/bluetooth/public/interfaces/bluetooth.mojom
@@ -0,0 +1,35 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+

[ortuno, 2016/09/22 08:32:54]

nit: remove new line

[mbrunson, 2016/09/24 01:05:47]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module bluetooth;

[ortuno, 2016/09/22 08:32:54]

scheib: Should we add a note mentioning that this is experimental and shouldn't
be used by any clients that what a stable API?

[scheib, 2016/09/23 20:53:51]

Use:
module bluetooth.mojom

I think we should use gn's visibility to restrict access for now:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/check.md

+
+struct DeviceInfo {
+  string? name;
+  string name_for_display;
+  string id;
+  string address;
+  uint16 device_id;

[ortuno, 2016/09/22 08:32:54]

nit: there was a comment about this on the design doc. I'm OK with landing this
and then removing depending on the outcome of that discussion but if you can get
a resolution sooner it would be better.

[mbrunson, 2016/09/24 01:05:47]

I think just removing it entirely for now would be better. Many, many things
will be added to this file later so I think it's OK to omit things we're not
sure about for now unless it hinders manual testing.

+  uint16 product_id;
+  uint16 vendor_id;
+};
+
+interface Adapter {

[scheib, 2016/09/23 20:53:51]

ortuno: what do you think here,
I think that we should keep related interfaces in individual files. e.g. this
file should be renamed to adapter.mojom, and the internals interface moved out
to 
chrome/browser/ui/webui/bluetooth/bluetooth_internals.mojom

[mbrunson, 2016/09/24 01:05:47]

The internals interface was not supposed to be in here to begin with. I must
have left it in here when I copied this file to make the
bluetooth_internals.mojom.

[ortuno, 2016/09/26 01:57:56]

Separating in the interfaces in files sounds good.

+  // Retrieves the list of devices that can be detected

[ortuno, 2016/09/22 08:32:54]

I want to get rid of this function but since that discussion is still ongoing I
think it's OK to land this but we should add more detail regarding what the
function returns i.e. Retrieves the list of the devices known by the adapter.
This includes Connected Devices, GATT Connected Devices, Paired Devices and
Devices discovered by during a classic of low-energy scan.

nit: Period at the end of sentence.

[mbrunson, 2016/09/24 01:05:47]

Done.

+  GetDevices(int8 index, int8 count) => (array<DeviceInfo> devices);

[ortuno, 2016/09/22 08:32:54]

Could you mention the purpose of the two arguments in the comment?

Also question: What's the use case for them?

[ortuno, 2016/09/22 08:32:54]

Could you mention the purpose of the two arguments in the comment?

Also question: What's the use case for them?

[mbrunson, 2016/09/24 01:05:47]

These should probably be removed. The original use case was for pagination on
the internals page but with the move to a more generic interface that seems like
something that should be handled by the consumer of this.

+};
+
+interface AdapterClient {
+  // Called when a device has been detected

[ortuno, 2016/09/22 08:32:54]

nit: Called the first time a device is discovered.

Also period at the end of sentence.

[mbrunson, 2016/09/24 01:05:47]

Done.

+  DeviceAdded(DeviceInfo device);
+
+  // Called when a device can no longer be detected
+  DeviceRemoved(DeviceInfo device);

[ortuno, 2016/09/22 08:32:54]

nit: Called after the device hasn't been seen for 3 minutes.

Also period at the end of sentence.

[mbrunson, 2016/09/24 01:05:47]

Done.

+};
+
+interface InternalsPageHandler {

[scheib, 2016/09/23 20:53:51]

This interface shouldn't be in device/bluetooth

[mbrunson, 2016/09/24 01:05:47]

Done.

+  // Creates pipe for Bluetooth Adapter between |client| and |adapter|

[ortuno, 2016/09/22 08:32:54]

nit: Period at the end of sentence.

[mbrunson, 2016/09/24 01:05:47]

Done.

+  GetAdapterService(Adapter& adapter,
+                    AdapterClient client);
+};