bluetooth: Add device list retrieval for chrome://bluetooth-internals

chrome/browser/ui/webui/bluetooth_internals/services/bluetooth_adapter_service.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_BLUETOOTH_INTERNALS_SERVICES_BLUETOOTH_ADAPTER_SERVICE_H_
+#define CHROME_BROWSER_UI_WEBUI_BLUETOOTH_INTERNALS_SERVICES_BLUETOOTH_ADAPTER_SERVICE_H_
+
+#include <set>
+#include <string>
+
+#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom.h"
+#include "chrome/browser/ui/webui/mojo_web_ui_handler.h"
+#include "device/bluetooth/bluetooth_adapter.h"
+#include "device/bluetooth/bluetooth_adapter_factory.h"
+#include "mojo/public/cpp/bindings/binding.h"
+
+// Implementation of Mojo BluetoothAdapter located in

[ortuno, 2016/09/26 01:57:56]

Should this be under the bluetooth: namespace?

[scheib, 2016/09/26 18:00:37]

I think yes, and the bluetooth service implementations under device/bluetooth/??
(possibly another subdirectory, e.g. bluetooth/service -- look for other
examples)

Also, I believe we can drop 'Bluetooth' from the class names, they'll all live
in the bluetooth namespace.

[mbrunson, 2016/09/28 02:18:22]

I've renamed and moved this to device/bluetooth.

+// device/bluetooth/public/interfaces/bluetooth.mojom.
+// It handles requests for Bluetooth adapter capabilities
+// and devices coming from the chrome://bluetooth-internals
+// page and uses the platform abstraction of device/bluetooth.
+// This class is instantiated on-demand via the GetAdapterService
+// function in BluetoothInternalsUI which creates a strong Mojo
+// binding that manages the lifetime of an instance of this class.
+class BluetoothAdapterService : public bluetooth::mojom::Adapter,
+                                public device::BluetoothAdapter::Observer {
+ public:
+  explicit BluetoothAdapterService(bluetooth::mojom::AdapterClientPtr client);
+  ~BluetoothAdapterService() override;
+
+  // bluetooth::mojom::AdapterService overrides:
+  void GetDevices(const GetDevicesCallback& callback) override;
+
+  // device::BluetoothAdapter::Observer overrides:
+  void DeviceAdded(device::BluetoothAdapter* adapter,
+                   device::BluetoothDevice* device) override;
+
+  void DeviceRemoved(device::BluetoothAdapter* adapter,
+                     device::BluetoothDevice* device) override;
+
+ private:
+  bluetooth::mojom::DeviceInfoPtr ConstructDeviceInfoStruct(

[ortuno, 2016/09/26 01:57:56]

The order of declaration should match the order of the definition:

https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

[mbrunson, 2016/09/28 02:18:22]

Done.

+      device::BluetoothDevice* device);
+  scoped_refptr<device::BluetoothAdapter> GetAdapter();
+  void GetDevicesImpl(const GetDevicesCallback& callback,
+                      scoped_refptr<device::BluetoothAdapter> adapter);
+  void OnGetAdapter(scoped_refptr<device::BluetoothAdapter> adapter);
+
+  scoped_refptr<device::BluetoothAdapter> adapter_;

[ortuno, 2016/09/26 01:57:56]

nit: Could you add comments for these?

[mbrunson, 2016/09/28 02:18:22]

Done.

+  std::set<std::string> addresses_;

[ortuno, 2016/09/26 01:57:56]

q: Why do you keep track of the devices? In other words why not just call
DeviceAdded and DeviceRemoved for all devices?

Also fyi std::set uses a tree whereas std::unordered_set uses a hash set.
Consider using unordered_set if you don't care about the order.

http://stackoverflow.com/questions/16075890/what-is-the-difference-between-se...

[mbrunson, 2016/09/28 02:18:22]

I have removed this and simplified the adapter service to be as thin of a
wrapper of device/bluetooth/bluetooth_adapter as possible. The less state, the
better, and it removes the immediate need of rigorous testing for the Mojo
service.

+  bluetooth::mojom::AdapterClientPtr client_;
+  base::WeakPtrFactory<BluetoothAdapterService> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(BluetoothAdapterService);
+};
+
+#endif  // CHROME_BROWSER_UI_WEBUI_BLUETOOTH_INTERNALS_SERVICES_BLUETOOTH_ADAPTER_SERVICE_H_