Remove pre-MD code from bookmark bar (Views).

Remove pre-MD code from bookmark bar (Views).

One small behavioral change: the drag/drop indicator uses
the text color, so it's actually visible on dark themes.

BUG=648281
Committed: https://crrev.com/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee
Cr-Commit-Position: refs/heads/master@{#420354}

[Evan Stade, 2016-09-21 19:59:11]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 20:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:41:34]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-21 21:37:51]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2016-09-21 21:38:43]

Description was changed from

==========
Remove pre-MD code from bookmark bar (Views).

BUG=648281
==========

to

==========
Remove pre-MD code from bookmark bar (Views).

One small behavioral change: the drag/drop indicator uses
the text color, so it's actually visible on dark themes.

BUG=648281
==========

[Peter Kasting, 2016-09-22 03:23:27]

LGTM

https://codereview.chromium.org/2357353003/diff/1/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/2357353003/diff/1/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1205: // |browser_view_|
can be nullptr during tests.
Nit: Prefer "null" to "nullptr" in comments, it just reads a little more nicely
(multiple places)

[Evan Stade, 2016-09-22 14:35:11]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-22 14:35:27]

https://codereview.chromium.org/2357353003/diff/1/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/2357353003/diff/1/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1205: // |browser_view_|
can be nullptr during tests.
On 2016/09/22 03:23:27, Peter Kasting wrote:
> Nit: Prefer "null" to "nullptr" in comments, it just reads a little more
nicely
> (multiple places)

Done.

[commit-bot: I haz the power, 2016-09-22 14:35:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 15:45:53]

Description was changed from

==========
Remove pre-MD code from bookmark bar (Views).

One small behavioral change: the drag/drop indicator uses
the text color, so it's actually visible on dark themes.

BUG=648281
==========

to

==========
Remove pre-MD code from bookmark bar (Views).

One small behavioral change: the drag/drop indicator uses
the text color, so it's actually visible on dark themes.

BUG=648281
==========

[commit-bot: I haz the power, 2016-09-22 15:45:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 15:47:24]

Description was changed from

==========
Remove pre-MD code from bookmark bar (Views).

One small behavioral change: the drag/drop indicator uses
the text color, so it's actually visible on dark themes.

BUG=648281
==========

to

==========
Remove pre-MD code from bookmark bar (Views).

One small behavioral change: the drag/drop indicator uses
the text color, so it's actually visible on dark themes.

BUG=648281

Committed: https://crrev.com/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee
Cr-Commit-Position: refs/heads/master@{#420354}
==========

[commit-bot: I haz the power, 2016-09-22 15:47:25]

Patchset 2 (id:??) landed as
https://crrev.com/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee
Cr-Commit-Position: refs/heads/master@{#420354}