Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2357353002: split tight quads and cubics (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

split tight quads and conics Tight quads and conics may nearly fold over on themselves, confusing coincidence against other curves. Split them at their max curvature early on to avoid complicating later logic. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357353002 Committed: https://skia.googlesource.com/skia/+/27c015dfcf4e2b8fb1abe327cc40204e2a4f452a

Patch Set 1 #

Patch Set 2 : update best tiger b #

Patch Set 3 : fix linux build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -155 lines) Patch
M src/pathops/SkAddIntersections.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpContour.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 4 chunks +93 lines, -47 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkReduceOrder.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/pathops/SkReduceOrder.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/PathOpsConicLineIntersectionTest.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 2 chunks +22 lines, -0 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyFailTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/PathOpsThreeWayTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/pathops_sorter.htm View 2 chunks +29 lines, -4 lines 0 comments Download
M tools/pathops_visualizer.htm View 2 chunks +144 lines, -82 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357353002/40001
4 years, 2 months ago (2016-09-23 12:12:02 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 12:47:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/27c015dfcf4e2b8fb1abe327cc40204e2a4f452a

Powered by Google App Engine
This is Rietveld 408576698