scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md - Issue 2357343004: chromium_tests: automatically set up test genrators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md

Issue 2357343004: chromium_tests: automatically set up test genrators (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py ('K') | « scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py ('k') | scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py » ('j') | scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md b/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md

index 4e794380a5ab959e38ef8877e1819d4e9cbab936..7f68b91c661dd158fcaff387c9cc090086b47723 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md

@@ -145,19 +145,6 @@ Add it to the JSON test spec. Example ([`src/testing/buildbot/chromium.linux.jso

]

}

-Note that this relies on gtest generator in the bot configuration in the

-`chromium_tests` module. For example, given the file [`scripts/slave/recipe_modules/chromium_tests/chromium_linux.py`](https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py)

-, you would need:

- 'Linux Builder': {

- ...

- 'test_generators': [

- steps.generate_gtest,

- ...

- ],

- ...

- },

Changes to the JSON file can be tested on the trybots, and you can verify that

they take effect and build still passes.