scripts/slave/recipe_modules/chromium_tests/api.py - Issue 2357343004: chromium_tests: automatically set up test genrators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 2357343004: chromium_tests: automatically set up test genrators (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_tests/api.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py

index 941ce3a9fdcdbea24c41aefc2bcde916e30708c6..6ea409886eb760152f0f14f0681571b2ef13dc24 100644

--- a/scripts/slave/recipe_modules/chromium_tests/api.py

+++ b/scripts/slave/recipe_modules/chromium_tests/api.py

@@ -234,7 +234,7 @@ class ChromiumTestsApi(recipe_api.RecipeApi):

bot_update_step, enable_swarming=enable_swarming,

swarming_dimensions=swarming_dimensions,

scripts_compile_targets=scripts_compile_targets)) +

- tests)

+ tuple(tests))

ghost stip (do not use) 2016/09/22 23:25:48 did this not work before?

Paweł Hajdan Jr. 2016/09/23 01:14:54 Bots where this doesn't work (they use frozenset)

return tests

def read_test_spec(self, api, test_spec_file):