runtime/vm/flow_graph_compiler_dbc.cc - Issue 2357343003: Fix lazy deoptimization in the presence of exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2357343003: Fix lazy deoptimization in the presence of exceptions (Closed)

Patch Set: Ensure space for patching on ARM/MIPS archs Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_dbc.cc

diff --git a/runtime/vm/flow_graph_compiler_dbc.cc b/runtime/vm/flow_graph_compiler_dbc.cc

index fc1534ddb11a8a0cd426f80e2385e90de3b4f7a5..69dd8ad56a4dbb769baa300748b7720b95c94d86 100644

--- a/runtime/vm/flow_graph_compiler_dbc.cc

+++ b/runtime/vm/flow_graph_compiler_dbc.cc

@@ -198,7 +198,7 @@ void FlowGraphCompiler::RecordAfterCall(Instruction* instr) {

// On all other architectures caller drops outgoing arguments itself

// hence the difference.

pending_deoptimization_env_->DropArguments(instr->ArgumentCount());

- AddDeoptIndexAtCall(deopt_id_after, instr->token_pos());

+ AddDeoptIndexAtCall(deopt_id_after);

} else {

// Add deoptimization continuation point after the call and before the

// arguments are removed.

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »