Issue 2357333002: allow clip calls w/o op param, remove unnecessary kReplace ops

Issue 2357333002: allow clip calls w/o op param, remove unnecessary kReplace ops (Closed)

Created:
4 years, 3 months ago by reed1

Modified:
4 years, 3 months ago

Reviewers:
f(malita)

CC:
reviews_skia.org

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -42 lines)			Patch
M	gm/aaclip.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/bigblurs.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/circularclips.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gm/clip_strokerect.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gm/complexclip.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/complexclip3.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/distantclip.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/imagefilters.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/path_stroke_with_zero_length.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gm/pathopsinverse.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gm/pathopsskpclip.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gm/rrectclipdrawpaint.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	gm/rrects.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/samplerstress.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/simpleaaclip.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gm/skbug1719.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkCanvas.h	View	3 chunks	+21 lines, -3 lines	0 comments	Download
M	samplecode/SampleClipDrawMatch.cpp	View	1 chunk	+13 lines, -13 lines	0 comments	Download

Total messages: 11 (7 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357333002/1

4 years, 3 months ago (2016-09-21 18:02:42 UTC) #9

commit-bot: I haz the power

4 years, 3 months ago (2016-09-21 18:15:12 UTC) #11

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/669983856d99b9312be3166b7dd1f8483a90c315