<webview>: Move media request to chrome

<webview>: Move media request to chrome

BUG=330264
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264029

[lazyboy, 2014-04-11 20:13:19]

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
File chrome/browser/guestview/webview/webview_guest.cc (right):

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
chrome/browser/guestview/webview/webview_guest.cc:98: case
WEB_VIEW_PERMISSION_TYPE_MEDIA:
nit: sort the case-s, here and in other places + in the enum.

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
chrome/browser/guestview/webview/webview_guest.cc:902: base::Unretained(this),
nit: indent
WebViewGuest going away before the callback gets called would cause problem
here.

https://codereview.chromium.org/235733002/diff/20001/content/browser/browser_...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/235733002/diff/20001/content/browser/browser_...
content/browser/browser_plugin/browser_plugin_guest.cc:1616:
MEDIA_DEVICE_INVALID_STATE,
indent

https://codereview.chromium.org/235733002/diff/20001/tools/metrics/actions/ac...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/235733002/diff/20001/tools/metrics/actions/ac...
tools/metrics/actions/actions.xml:10717: <owner>Please list the metric's owners.
Add more owner tags as needed.</owner>
You should fill these in.

[Fady Samuel, 2014-04-11 21:52:31]

PTAL

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
File chrome/browser/guestview/webview/webview_guest.cc (right):

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
chrome/browser/guestview/webview/webview_guest.cc:98: case
WEB_VIEW_PERMISSION_TYPE_MEDIA:
On 2014/04/11 20:13:20, lazyboy wrote:
> nit: sort the case-s, here and in other places + in the enum.

Done.

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
chrome/browser/guestview/webview/webview_guest.cc:902: base::Unretained(this),
On 2014/04/11 20:13:20, lazyboy wrote:
> nit: indent
> WebViewGuest going away before the callback gets called would cause problem
> here.

Done.

https://codereview.chromium.org/235733002/diff/20001/content/browser/browser_...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/235733002/diff/20001/content/browser/browser_...
content/browser/browser_plugin/browser_plugin_guest.cc:1616:
MEDIA_DEVICE_INVALID_STATE,
On 2014/04/11 20:13:20, lazyboy wrote:
> indent

Done.

https://codereview.chromium.org/235733002/diff/20001/tools/metrics/actions/ac...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/235733002/diff/20001/tools/metrics/actions/ac...
tools/metrics/actions/actions.xml:10717: <owner>Please list the metric's owners.
Add more owner tags as needed.</owner>
On 2014/04/11 20:13:20, lazyboy wrote:
> You should fill these in.

Done.

[lazyboy, 2014-04-11 21:56:26]

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
File chrome/browser/guestview/webview/webview_guest.cc (right):

https://codereview.chromium.org/235733002/diff/20001/chrome/browser/guestview...
chrome/browser/guestview/webview/webview_guest.cc:902: base::Unretained(this),
On 2014/04/11 21:52:31, Fady Samuel wrote:
> On 2014/04/11 20:13:20, lazyboy wrote:
> > nit: indent
> > WebViewGuest going away before the callback gets called would cause problem
> > here.
> 
> Done.

Do we not need to fix the base::Unretained() issue in the comment?

[lazyboy, 2014-04-11 23:18:19]

lgtm

[Fady Samuel, 2014-04-14 17:32:38]

+jam@ for content/public changes.

[jam, 2014-04-14 19:54:47]

just to make sure i'm understanding correctly (cs being down isn't helping!),
content right now doesn't have access to the WebContentsDelegate of the guest
view right? if so, lgtm

[Fady Samuel, 2014-04-14 20:03:31]

On 2014/04/14 19:54:47, jam wrote:
> just to make sure i'm understanding correctly (cs being down isn't helping!),
> content right now doesn't have access to the WebContentsDelegate of the guest
> view right? if so, lgtm

Right now BrowserPluginGuest is the WebContentsDelegate of the guest
WebContents. In the future, this will no longer be the case (we are
transitioning in that direction). This will result in a lot of code cleanup.

[Fady Samuel, 2014-04-14 22:39:09]

+asvitkine@ for actions.xml

[Alexei Svitkine (slow), 2014-04-15 15:39:13]

lgtm

[Fady Samuel, 2014-04-15 19:11:34]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-04-15 19:12:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/235733002/120001

[commit-bot: I haz the power, 2014-04-15 19:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 19:31:31]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Fady Samuel, 2014-04-15 20:21:43]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-04-15 20:23:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/235733002/120001

[commit-bot: I haz the power, 2014-04-15 23:05:58]

Change committed as 264029