Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/x64/handler-compiler-x64.cc

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/s390/handler-compiler-s390.cc ('k') | src/ic/x87/handler-compiler-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 DCHECK(holder()->HasNamedInterceptor()); 606 DCHECK(holder()->HasNamedInterceptor());
607 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate())); 607 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate()));
608 __ PopReturnAddressTo(scratch2()); 608 __ PopReturnAddressTo(scratch2());
609 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(), 609 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(),
610 holder()); 610 holder());
611 __ PushReturnAddressFrom(scratch2()); 611 __ PushReturnAddressFrom(scratch2());
612 612
613 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor); 613 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor);
614 } 614 }
615 615
616 void NamedStoreHandlerCompiler::ZapStackArgumentsRegisterAliases() {
617 STATIC_ASSERT(!StoreWithVectorDescriptor::kPassLastArgsOnStack);
618 }
616 619
617 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 620 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
618 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback, 621 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback,
619 LanguageMode language_mode) { 622 LanguageMode language_mode) {
620 Register holder_reg = Frontend(name); 623 Register holder_reg = Frontend(name);
621 624
622 __ PopReturnAddressTo(scratch1()); 625 __ PopReturnAddressTo(scratch1());
623 __ Push(receiver()); 626 __ Push(receiver());
624 __ Push(holder_reg); 627 __ Push(holder_reg);
625 // If the callback cannot leak, then push the callback directly, 628 // If the callback cannot leak, then push the callback directly,
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 // Return the generated code. 686 // Return the generated code.
684 return GetCode(kind(), name); 687 return GetCode(kind(), name);
685 } 688 }
686 689
687 690
688 #undef __ 691 #undef __
689 } // namespace internal 692 } // namespace internal
690 } // namespace v8 693 } // namespace v8
691 694
692 #endif // V8_TARGET_ARCH_X64 695 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ic/s390/handler-compiler-s390.cc ('k') | src/ic/x87/handler-compiler-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698