AOT: Add a separate switchable call state for unlinked calls.

AOT: Add a separate switchable call state for unlinked calls.

Flutter gallery
Isolate(CodeSize): 2213525 =>
Isolate(CodeSize): 2070395 (-6.4%)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/2bc6e0a71da7159df36ed3eca3c3d574989e6d00

[rmacnak, 2016-09-22 17:24:35]

Description was changed from

==========
unlinkedcall

BUG=
==========

to

==========
AOT: Add a separate switchable call state for unlinked calls.

Flutter gallery
Isolate(CodeSize): 2213525 =>
Isolate(CodeSize): 2070395 (-6.4%)
==========

[rmacnak, 2016-09-22 17:24:47]

Description was changed from

==========
AOT: Add a separate switchable call state for unlinked calls.

Flutter gallery
Isolate(CodeSize): 2213525 =>
Isolate(CodeSize): 2070395 (-6.4%)
==========

to

==========
AOT: Add a separate switchable call state for unlinked calls.

Flutter gallery
Isolate(CodeSize): 2213525 =>
Isolate(CodeSize): 2070395 (-6.4%)
==========

[rmacnak, 2016-09-22 17:25:05]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-09-23 17:58:00]

LGTM

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:12623: RawUnlinkedCall* UnlinkedCall::New() {
Since there is no initializing code, this could be simplified to avoid handle
allocation (see TokenStream::New).

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/stub_code_ar...
File runtime/vm/stub_code_arm.cc (right):

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/stub_code_ar...
runtime/vm/stub_code_arm.cc:2135: __ PushObject(Object::null_object());  //
Result.
Would it be worth filling the result slot with smi-zero instead of object null?

[rmacnak, 2016-09-26 17:32:54]

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:12623: RawUnlinkedCall* UnlinkedCall::New() {
On 2016/09/23 17:57:59, Florian Schneider wrote:
> Since there is no initializing code, this could be simplified to avoid handle
> allocation (see TokenStream::New).

Done.

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/stub_code_ar...
File runtime/vm/stub_code_arm.cc (right):

https://codereview.chromium.org/2357313003/diff/80001/runtime/vm/stub_code_ar...
runtime/vm/stub_code_arm.cc:2135: __ PushObject(Object::null_object());  //
Result.
On 2016/09/23 17:57:59, Florian Schneider wrote:
> Would it be worth filling the result slot with smi-zero instead of object
null?

Maybe. I'll create another CL that makes that change for all the runtime calls.

[rmacnak, 2016-09-26 17:34:40]

Description was changed from

==========
AOT: Add a separate switchable call state for unlinked calls.

Flutter gallery
Isolate(CodeSize): 2213525 =>
Isolate(CodeSize): 2070395 (-6.4%)
==========

to

==========
AOT: Add a separate switchable call state for unlinked calls.

Flutter gallery
Isolate(CodeSize): 2213525 =>
Isolate(CodeSize): 2070395 (-6.4%)

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2bc6e0a71da7159df36ed3eca3c3d574989e6d00
==========

[rmacnak, 2016-09-26 17:34:42]

Committed patchset #6 (id:100001) manually as
2bc6e0a71da7159df36ed3eca3c3d574989e6d00 (presubmit successful).