Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2357293002: Rename m_pApp to m_pEnv (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
npm, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename m_pApp to m_pEnv The m_pApp variable holds a CPDFSDK_Environment. This Cl renames the variable to be m_pEnv so as not to confuse with the various App classes that exist. Committed: https://pdfium.googlesource.com/pdfium/+/5819e4f334521cb1599f3d5f1f28df40528727ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -66 lines) Patch
M fpdfsdk/formfiller/cffl_checkbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 4 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 17 chunks +36 lines, -36 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-21 16:07:34 UTC) #4
Wei Li
lgtm
4 years, 3 months ago (2016-09-21 16:58:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357293002/1
4 years, 3 months ago (2016-09-21 17:13:54 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:14:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5819e4f334521cb1599f3d5f1f28df405287...

Powered by Google App Engine
This is Rietveld 408576698