Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2357283002: Move PackageIndexAssembler into analysis_server. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2251 lines) Patch
M pkg/analysis_server/lib/src/services/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/index/index_unit.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/index/index_unit_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
D pkg/analyzer/lib/src/summary/index_unit.dart View 1 chunk +0 lines, -908 lines 0 comments Download
D pkg/analyzer/test/src/summary/index_unit_test.dart View 1 chunk +0 lines, -1340 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-21 15:42:09 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2357283002/diff/1/pkg/analyzer/test/src/summary/test_all.dart File pkg/analyzer/test/src/summary/test_all.dart (right): https://codereview.chromium.org/2357283002/diff/1/pkg/analyzer/test/src/summary/test_all.dart#newcode29 pkg/analyzer/test/src/summary/test_all.dart:29: index_unit_test.main(); Doesn't this need to be deleted too?
4 years, 3 months ago (2016-09-21 15:45:42 UTC) #2
scheglov
4 years, 3 months ago (2016-09-21 15:54:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bdc024a303457acff274cc44d523f3d355fbfb49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698