src/image/SkImage.cpp - Issue 2357273002: Add output format properties to SkImageFilter::Context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkImage.cpp

Issue 2357273002: Add output format properties to SkImageFilter::Context (Closed)

Patch Set: Made constructor explicit, fixed call sites Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/image/SkImage.cpp

diff --git a/src/image/SkImage.cpp b/src/image/SkImage.cpp

index 6e65050a657e1d4557212d5dfd50eb186cf3fbeb..2870f31ef1859445218851166bcf926872f3e8cb 100644

--- a/src/image/SkImage.cpp

+++ b/src/image/SkImage.cpp

@@ -346,7 +346,9 @@ sk_sp<SkImage> SkImage::makeWithFilter(const SkImageFilter* filter, const SkIRec

SkAutoTUnref<SkImageFilterCache> cache(

SkImageFilterCache::Create(SkImageFilterCache::kDefaultTransientSize));

- SkImageFilter::Context context(SkMatrix::I(), clipBounds, cache.get());

+ SkImageFilter::OutputProperties outputProperties(as_IB(this)->onImageInfo().colorSpace());

+ SkImageFilter::Context context(SkMatrix::I(), clipBounds, cache.get(), outputProperties);

sk_sp<SkSpecialImage> result =

filter->filterImage(srcSpecialImage.get(), context, offset);