Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2357263007: roll clang-format 258123:282138 (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
dcheng, scottmg
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

roll clang-format 258123:282138 Brings in several months of changes. Most notably, columns in java files should align better. Mac and linux binaries are about 20% larger, Windows is over 50% larger for some reason (1.3MB -> 2MB) -- maybe I used MSVC2013 and the old one was build with MSVC2010? BUG=649842 R=dcheng@chromium.org Committed: 86f7e41d9424b9d8faf66c601b129855217f9a08

Patch Set 1 #

Patch Set 2 : deps too #

Patch Set 3 : deps for real #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M clang_format/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M linux64/clang-format.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mac/clang-format.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M win/clang-format.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
4 years, 3 months ago (2016-09-23 22:19:39 UTC) #4
dcheng
lgtm
4 years, 3 months ago (2016-09-23 22:22:05 UTC) #5
Nico
Committed patchset #3 (id:40001) manually as 86f7e41d9424b9d8faf66c601b129855217f9a08 (presubmit successful).
4 years, 3 months ago (2016-09-23 22:23:41 UTC) #8
scottmg
4 years, 3 months ago (2016-09-23 22:28:32 UTC) #9
Message was sent while issue was closed.
(The current version is statically linked so I can't easily tell which CRT it's
using to guess.)

You built the last ninja.exe with clang-cl right? Maybe worth trying here? Or
not caring sgtm too.

Powered by Google App Engine
This is Rietveld 408576698