Next attempt at defining browsing context

Next attempt at defining browsing context

R=dcheng@chromium.org, domenic@chromium.org
BUG=

Committed: https://crrev.com/6da848690fd6602c8b80a64093b68e3a1363debd
Cr-Commit-Position: refs/heads/master@{#420662}

[domenic, 2016-09-23 13:23:35]

lgtm \o/

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
File third_party/WebKit/Source/SpecMapping.md (right):

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
third_party/WebKit/Source/SpecMapping.md:16:
[Frame](https://cs.chromium.org/Source/core/frame/Frame.h) interface
If you click on this you get a search results page which is a bit sad. Is
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Fra...
better?

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
third_party/WebKit/Source/SpecMapping.md:30:
name](https://cs.chromium.org/Source/bindings/core/v8/WindowProxy.cpp).
Header file
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...)
or .cpp?

[dcheng, 2016-09-23 16:16:14]

LGTM with domenic's comments addressed.

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
File third_party/WebKit/Source/SpecMapping.md (right):

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
third_party/WebKit/Source/SpecMapping.md:30:
name](https://cs.chromium.org/Source/bindings/core/v8/WindowProxy.cpp).
On 2016/09/23 13:23:35, domenic wrote:
> Header file
>
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...)
> or .cpp?

Agree that .h would be better here for consistency with LocalFrame.

[jochen (gone - plz use gerrit), 2016-09-23 16:42:20]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-23 16:42:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2357263006/#ps20001
(title: "updates")

[jochen (gone - plz use gerrit), 2016-09-23 16:42:21]

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
File third_party/WebKit/Source/SpecMapping.md (right):

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
third_party/WebKit/Source/SpecMapping.md:16:
[Frame](https://cs.chromium.org/Source/core/frame/Frame.h) interface
On 2016/09/23 at 13:23:35, domenic wrote:
> If you click on this you get a search results page which is a bit sad. Is
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Fra...
better?

test files... :(

https://codereview.chromium.org/2357263006/diff/1/third_party/WebKit/Source/S...
third_party/WebKit/Source/SpecMapping.md:30:
name](https://cs.chromium.org/Source/bindings/core/v8/WindowProxy.cpp).
On 2016/09/23 at 16:16:14, dcheng wrote:
> On 2016/09/23 13:23:35, domenic wrote:
> > Header file
> >
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...)
> > or .cpp?
> 
> Agree that .h would be better here for consistency with LocalFrame.

done

[jochen (gone - plz use gerrit), 2016-09-23 17:22:23]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-23 17:22:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2357263006/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2016-09-23 17:22:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:11:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 18:14:34]

Description was changed from

==========
Next attempt at defining browsing context

R=dcheng@chromium.org, domenic@chromium.org
BUG=
==========

to

==========
Next attempt at defining browsing context

R=dcheng@chromium.org, domenic@chromium.org
BUG=

Committed: https://crrev.com/6da848690fd6602c8b80a64093b68e3a1363debd
Cr-Commit-Position: refs/heads/master@{#420662}
==========

[commit-bot: I haz the power, 2016-09-23 18:14:35]

Patchset 2 (id:??) landed as
https://crrev.com/6da848690fd6602c8b80a64093b68e3a1363debd
Cr-Commit-Position: refs/heads/master@{#420662}