Chromium Code Reviews

Issue 2357263002: Update status for failing resource tests. (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 2 months ago
Reviewers:
Bob Nystrom, nweiz
CC:
reviews_dartlang.org, nweiz
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for failing resource tests. BUG=https://github.com/dart-lang/pub/issues/1446 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/4ef3e3e8ad8089733d617505cc66fa3d8049b4ae

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+26 lines, -9 lines)
M test/global/run/resource_test.dart View 3 chunks +6 lines, -3 lines 0 comments
M test/run/resource_test.dart View 4 chunks +8 lines, -4 lines 1 comment
M test/test_pub.dart View 2 chunks +12 lines, -2 lines 0 comments

Messages

Total messages: 8 (3 generated)
Bill Hesse
4 years, 3 months ago (2016-09-21 15:00:24 UTC) #2
Bob Nystrom
lgtm
4 years, 3 months ago (2016-09-21 16:28:36 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as 4ef3e3e8ad8089733d617505cc66fa3d8049b4ae (presubmit successful).
4 years, 3 months ago (2016-09-21 16:49:24 UTC) #5
nweiz
https://codereview.chromium.org/2357263002/diff/1/test/run/resource_test.dart File test/run/resource_test.dart (right): https://codereview.chromium.org/2357263002/diff/1/test/run/resource_test.dart#newcode58 test/run/resource_test.dart:58: skip: "Issue https://github.com/dart-lang/pub/issues/1446"); For future reference: If you want ...
4 years, 2 months ago (2016-09-27 22:15:04 UTC) #7
Bill Hesse
4 years, 2 months ago (2016-09-27 22:49:43 UTC) #8
Message was sent while issue was closed. 
On 2016/09/27 22:15:04, nweiz wrote:
> https://codereview.chromium.org/2357263002/diff/1/test/run/resource_test.dart
> File test/run/resource_test.dart (right):
> 
>
https://codereview.chromium.org/2357263002/diff/1/test/run/resource_test.dart...
> test/run/resource_test.dart:58: skip: "Issue
> https://github.com/dart-lang/pub/issues/1446%22);
> For future reference: If you want to skip all the tests in a file, you can add
> @Skip() to the top of the file rather than skipping each test individually.

Yes, I only noticed after doing all of the tests that there were no others in
the file, and I had done the entire file.

Powered by Google App Engine