Make the I in IFormFiller explicit

Make the I in IFormFiller explicit

Typically the I prefix means Interface, except for CFFL_IFormFiller where it
means Interactive. Rename CFFL_IFormFiller to CFFL_InteractiveFormFiller to
make the meaning explicit.

Committed: https://pdfium.googlesource.com/pdfium/+/b94d7c9216160269d43a722b8e216790ba4b5d3b

[dsinclair, 2016-09-21 17:47:17]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-09-21 17:47:17]

PTAL. It's longer, but I think it's a lot clearer.

[dsinclair, 2016-09-21 17:47:22]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 17:47:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-21 18:15:30]

LGTM, but I'd shorten up the locals.

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/cpdfsdk_interform.cpp
File fpdfsdk/cpdfsdk_interform.cpp (right):

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/cpdfsdk_interform.c...
fpdfsdk/cpdfsdk_interform.cpp:345: CFFL_InteractiveFormFiller*
pInteractiveFormFiller =
nit: if you wanted to save space, you could call the local |pFormFiller|, since
it follows that an interactive form filler is some sort of form filler.

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/formfiller/cffl_che...
File fpdfsdk/formfiller/cffl_checkbox.cpp (right):

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/formfiller/cffl_che...
fpdfsdk/formfiller/cffl_checkbox.cpp:47: ASSERT(pInteractiveFormFiller);
nit: we'll segv at line 55, not sure this helps.

[commit-bot: I haz the power, 2016-09-21 18:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:19:56]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-21 18:29:19]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-21 18:29:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2357203003/#ps40001
(title: "Remove locals")

[commit-bot: I haz the power, 2016-09-21 18:29:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-21 18:34:01]

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/cpdfsdk_interform.cpp
File fpdfsdk/cpdfsdk_interform.cpp (right):

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/cpdfsdk_interform.c...
fpdfsdk/cpdfsdk_interform.cpp:345: CFFL_InteractiveFormFiller*
pInteractiveFormFiller =
On 2016/09/21 18:15:30, Tom Sepez wrote:
> nit: if you wanted to save space, you could call the local |pFormFiller|,
since
> it follows that an interactive form filler is some sort of form filler.

Done.

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/formfiller/cffl_che...
File fpdfsdk/formfiller/cffl_checkbox.cpp (right):

https://codereview.chromium.org/2357203003/diff/1/fpdfsdk/formfiller/cffl_che...
fpdfsdk/formfiller/cffl_checkbox.cpp:47: ASSERT(pInteractiveFormFiller);
On 2016/09/21 18:15:30, Tom Sepez wrote:
> nit: we'll segv at line 55, not sure this helps.


Dropped the local all together.

[commit-bot: I haz the power, 2016-09-21 19:07:02]

Description was changed from

==========
Make the I in IFormFiller explicit

Typically the I prefix means Interface, except for CFFL_IFormFiller where it
means Interactive. Rename CFFL_IFormFiller to CFFL_InteractiveFormFiller to
make the meaning explicit.
==========

to

==========
Make the I in IFormFiller explicit

Typically the I prefix means Interface, except for CFFL_IFormFiller where it
means Interactive. Rename CFFL_IFormFiller to CFFL_InteractiveFormFiller to
make the meaning explicit.

Committed:
https://pdfium.googlesource.com/pdfium/+/b94d7c9216160269d43a722b8e216790ba4b...
==========

[commit-bot: I haz the power, 2016-09-21 19:07:03]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b94d7c9216160269d43a722b8e216790ba4b...