| Index: chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
|
| diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
|
| index fd3aa896f993ec5ed097e34156846632a571de77..67d2ec86c63e0109c9a3d63a05d2a9e464786238 100644
|
| --- a/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
|
| +++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
|
| @@ -31,7 +31,6 @@ public class ChromeBackgroundServiceTest extends InstrumentationTestCase {
|
| static class MockTaskService extends ChromeBackgroundService {
|
| private boolean mDidLaunchBrowser = false;
|
| private boolean mDidFetchSnippets = false;
|
| - private boolean mDidRescheduleSnippets = false;
|
| private boolean mHasPrecacheInstance = true;
|
| private boolean mPrecachingStarted = false;
|
|
|
| @@ -46,11 +45,6 @@ public class ChromeBackgroundServiceTest extends InstrumentationTestCase {
|
| }
|
|
|
| @Override
|
| - protected void rescheduleSnippets() {
|
| - mDidRescheduleSnippets = true;
|
| - }
|
| -
|
| - @Override
|
| protected boolean hasPrecacheInstance() {
|
| return mHasPrecacheInstance;
|
| }
|
| @@ -66,16 +60,13 @@ public class ChromeBackgroundServiceTest extends InstrumentationTestCase {
|
| // to onRunTask, it will be enqueued after any possible call to launchBrowser, and we
|
| // can reliably check whether launchBrowser was called.
|
| protected void checkExpectations(final boolean expectedLaunchBrowser,
|
| - final boolean expectedPrecacheStarted, final boolean expectedFetchSnippets,
|
| - final boolean expectedRescheduleSnippets) {
|
| + final boolean expectedPrecacheStarted, final boolean expectedFetchSnippets) {
|
| ThreadUtils.runOnUiThread(new Runnable() {
|
| @Override
|
| public void run() {
|
| assertEquals("StartedService", expectedLaunchBrowser, mDidLaunchBrowser);
|
| assertEquals("StartedPrecache", expectedPrecacheStarted, mPrecachingStarted);
|
| assertEquals("FetchedSnippets", expectedFetchSnippets, mDidFetchSnippets);
|
| - assertEquals("RescheduledSnippets", expectedRescheduleSnippets,
|
| - mDidRescheduleSnippets);
|
| }
|
| });
|
| }
|
| @@ -106,74 +97,60 @@ public class ChromeBackgroundServiceTest extends InstrumentationTestCase {
|
| }
|
|
|
| private void startOnRunTaskAndVerify(String taskTag, boolean shouldStart,
|
| - boolean shouldPrecache, boolean shouldFetchSnippets, boolean shouldRescheduleSnippets) {
|
| + boolean shouldPrecache, boolean shouldFetchSnippets) {
|
| mTaskService.onRunTask(new TaskParams(taskTag));
|
| - mTaskService.checkExpectations(
|
| - shouldStart, shouldPrecache, shouldFetchSnippets, shouldRescheduleSnippets);
|
| + mTaskService.checkExpectations(shouldStart, shouldPrecache, shouldFetchSnippets);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"BackgroundSync"})
|
| public void testBackgroundSyncNoLaunchBrowserWhenInstanceExists() {
|
| - startOnRunTaskAndVerify(BackgroundSyncLauncher.TASK_TAG, false, false, false, false);
|
| + startOnRunTaskAndVerify(BackgroundSyncLauncher.TASK_TAG, false, false, false);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"BackgroundSync"})
|
| public void testBackgroundSyncLaunchBrowserWhenInstanceDoesNotExist() {
|
| deleteSyncLauncherInstance();
|
| - startOnRunTaskAndVerify(BackgroundSyncLauncher.TASK_TAG, true, false, false, false);
|
| + startOnRunTaskAndVerify(BackgroundSyncLauncher.TASK_TAG, true, false, false);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"NTPSnippets"})
|
| public void testNTPSnippetsFetchWifiNoLaunchBrowserWhenInstanceExists() {
|
| - startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_WIFI, false, false, true, false);
|
| + startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_WIFI, false, false, true);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"NTPSnippets"})
|
| public void testNTPSnippetsFetchFallbackNoLaunchBrowserWhenInstanceExists() {
|
| - startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_FALLBACK, false, false, true, false);
|
| - }
|
| -
|
| - @SmallTest
|
| - @Feature({"NTPSnippets"})
|
| - public void testNTPSnippetsRescheduleNoLaunchBrowserWhenInstanceExists() {
|
| - startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_RESCHEDULE, false, false, false, true);
|
| + startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_FALLBACK, false, false, true);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"NTPSnippets"})
|
| public void testNTPSnippetsFetchWifiLaunchBrowserWhenInstanceDoesNotExist() {
|
| deleteSnippetsLauncherInstance();
|
| - startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_WIFI, true, false, true, false);
|
| + startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_WIFI, true, false, true);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"NTPSnippets"})
|
| public void testNTPSnippetsFetchFallbackLaunchBrowserWhenInstanceDoesNotExist() {
|
| deleteSnippetsLauncherInstance();
|
| - startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_FALLBACK, true, false, true, false);
|
| - }
|
| -
|
| - @SmallTest
|
| - @Feature({"NTPSnippets"})
|
| - public void testNTPSnippetsRescheduleLaunchBrowserWhenInstanceDoesNotExist() {
|
| - deleteSnippetsLauncherInstance();
|
| - startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_RESCHEDULE, true, false, false, true);
|
| + startOnRunTaskAndVerify(SnippetsLauncher.TASK_TAG_FALLBACK, true, false, true);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"Precache"})
|
| public void testPrecacheNoLaunchBrowserWhenInstanceExists() {
|
| - startOnRunTaskAndVerify(PrecacheController.PERIODIC_TASK_TAG, false, false, false, false);
|
| + startOnRunTaskAndVerify(PrecacheController.PERIODIC_TASK_TAG, false, false, false);
|
| }
|
|
|
| @SmallTest
|
| @Feature({"Precache"})
|
| public void testPrecacheLaunchBrowserWhenInstanceDoesNotExist() {
|
| mTaskService.deletePrecacheInstance();
|
| - startOnRunTaskAndVerify(PrecacheController.PERIODIC_TASK_TAG, true, true, false, false);
|
| + startOnRunTaskAndVerify(PrecacheController.PERIODIC_TASK_TAG, true, true, false);
|
| }
|
| }
|
|
|