[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through the stack.

src/full-codegen/full-codegen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/full-codegen/full-codegen.h"
 
 #include "src/ast/ast-numbering.h"
 #include "src/ast/ast.h"
 #include "src/ast/prettyprinter.h"
 #include "src/ast/scopes.h"
@@ skipping 219 matching lines @@
 }
 
 void FullCodeGenerator::CallLoadGlobalIC(TypeofMode typeof_mode,
                                          TypeFeedbackId id) {
   Handle<Code> ic = CodeFactory::LoadGlobalIC(isolate(), typeof_mode).code();
   CallIC(ic, id);
 }
 
 void FullCodeGenerator::CallStoreIC(TypeFeedbackId id) {
   Handle<Code> ic = CodeFactory::StoreIC(isolate(), language_mode()).code();
+
+  STATIC_ASSERT(!StoreDescriptor::kPassLastArgsOnStack ||
+                StoreDescriptor::kStackArgumentsCount == 2);
+  if (StoreDescriptor::kPassLastArgsOnStack) {
+    __ Push(StoreDescriptor::ValueRegister());
+    __ Push(StoreDescriptor::SlotRegister());
+  }

[mvstanton, 2016/09/22 08:06:24]

Would it be better to push these values directly onto the stack, instead of
loading them into registers and then pushing?

[Igor Sheludko, 2016/09/22 08:41:09]

Yes it would. Let me address this in a follow-up CL.

+
   CallIC(ic, id);
   RestoreContext();
 }
 
 void FullCodeGenerator::CallKeyedStoreIC() {
   Handle<Code> ic =
       CodeFactory::KeyedStoreIC(isolate(), language_mode()).code();
+
+  STATIC_ASSERT(!StoreDescriptor::kPassLastArgsOnStack ||
+                StoreDescriptor::kStackArgumentsCount == 2);
+  if (StoreDescriptor::kPassLastArgsOnStack) {
+    __ Push(StoreDescriptor::ValueRegister());
+    __ Push(StoreDescriptor::SlotRegister());
+  }
+
   CallIC(ic);
   RestoreContext();
 }
 
 void FullCodeGenerator::RecordJSReturnSite(Call* call) {
   // We record the offset of the function return so we can rebuild the frame
   // if the function was inlined, i.e., this is the return address in the
   // inlined function's frame.
   //
   // The bailout state is ignored.  We defensively set it to TOS_REGISTER, which
@@ skipping 1758 matching lines @@
   return info_->has_simple_parameters();
 }
 
 FunctionLiteral* FullCodeGenerator::literal() const { return info_->literal(); }
 
 #undef __
 
 
 }  // namespace internal
 }  // namespace v8