Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2357153002: [turbofan] Support for ConsString by escape analysis. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Support for ConsString by escape analysis. This add support for ConsString objects allocated inline to the escape analysis pass. The raw hash field in such strings needs special handling similar to existing raw fields. This also contains materialization code within the deoptimizer as usual. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-648737 BUG=chromium:648737 Committed: https://crrev.com/b097c6c4f110f563c464c8ab498035ac19080801 Cr-Commit-Position: refs/heads/master@{#39594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-648737.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-21 11:42:35 UTC) #3
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-21 11:45:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357153002/1
4 years, 3 months ago (2016-09-21 12:26:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 12:29:11 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 12:30:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b097c6c4f110f563c464c8ab498035ac19080801
Cr-Commit-Position: refs/heads/master@{#39594}

Powered by Google App Engine
This is Rietveld 408576698