services/ui/public/interfaces/window_manager.mojom - Issue 2357143004: mash: Support ShelfWindowWatcher via ShelfItem properties.

Unified Diff: services/ui/public/interfaces/window_manager.mojom

Issue 2357143004: mash: Support ShelfWindowWatcher via ShelfItem properties. (Closed)

Patch Set: Set Settings WmWindow title with a WmWindowObserver. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/public/interfaces/window_manager.mojom

diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom

index fb103d2b866588a9894a4c98f2201fdab1fc6b52..6417a593e591e937e6c7d93c9ce4be583699736f 100644

--- a/services/ui/public/interfaces/window_manager.mojom

+++ b/services/ui/public/interfaces/window_manager.mojom

@@ -48,6 +48,10 @@ interface WindowManager {

const string kRestoreBounds_Property = "prop:restore-bounds";

// Shadow style for the window. Type: mojom::ShadowStyle.

const string kShadowStyle_Property = "prop:shadow-style";

+ // The image resource ID that should be used as the shelf item's icon.

James Cook 2016/09/28 20:41:03 nit: Type? int?

msw 2016/09/28 23:27:46 Done.

+ const string kShelfIconId_Property = "prop:shelf-icon-id";

James Cook 2016/09/28 20:41:03 optional: What do you think of kShelfIcon*Resource

msw 2016/09/28 23:27:46 Done; renamed as you suggest. FYI: I'd like to jus

+ // The type of item that should be shown on the shelf for this window.

James Cook 2016/09/28 20:41:03 ditto Also, document what happens if this is not

msw 2016/09/28 23:27:46 Done.

+ const string kShelfItemType_Property = "prop:shelf-item-type";

// The window's show state. Type: ShowState.

const string kShowState_Property = "prop:show-state";

// The window bounds as set by user input. Type: gfx::Rect.